Use Node 20, Update Yarn and some dependencies. #3468

Akamig · 2023-10-30T06:13:34Z

Formatter Rome has been discontinued. rollback to prettier.
Bump Yarn to v4 (4.0.1)
Bump typescript to ^4.5.0 (4.9.5)
- nanobundle supports v5 ts though, it's dependancies does not supports v5 yet
~~Add WebCrypto export adapter for it's environment (CJS,MJS,Browser)~~
~~Add 'IsDigest" in tx sign.ts~~

Update

Let AwsKmsAccount handle digest / non digested form of Sign Command
Add WebCrypto export adapter for aws-kms-account

CLAassistant · 2023-10-30T06:13:40Z

All committers have signed the CLA.

Akamig · 2023-10-30T06:42:11Z

........It should work now. I guess. maybe.

@planetarium/tx/package.json

.github/workflows/yarn.yaml

moreal · 2023-10-30T06:43:33Z

@planetarium/account/src/Account.ts

@@ -7,7 +7,7 @@ import Signature from "./Signature.js";
 export interface Account {
  getAddress(): Promise<Address>;
  getPublicKey(): Promise<PublicKey>;
-  sign(message: Message): Promise<Signature>;
+  sign(message: Message, isDigest?: boolean): Promise<Signature>;


~~Isn't okay to update Account too?~~ I'm not sure it can be added to the interface level.

it's optional flag, so probably....

After some discussions, we decided to just handle this inside AWS-KMS

moreal · 2023-10-30T06:46:30Z

Please press button read-for-review when the CI passed 🙏🏻

Akamig · 2023-10-30T07:43:03Z

Akamig · 2023-10-30T08:28:31Z

yarn / build (lts/*) (pull_request) has failed due to AWS API timeout,
Check yarn / build (lts/*) (push) instead.
(It barely succeed in time , maybe longer timeout for this test is advised.)

pull-request-quantifier-deprecated · 2023-10-30T10:01:48Z

This PR has 132 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +70 -62
Percentile : 46.4%

Total files changed: 25

Change summary by file extension:
.yaml : +2 -2
.json : +40 -22
.cjs : +0 -26
.js : +3 -1
.yml : +3 -6
.ts : +22 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

moreal · 2023-10-30T11:28:02Z

@planetarium/account-aws-kms/tsconfig.json

@@ -1,15 +1,17 @@
 {
-  "include": ["./src", "*.d.ts", "*.ts"],
+  "include": ["./src", "*.d.ts", "src/*.ts"],


Isn't it included by ./src? 👀

just src also works since it's "at" rootDir.

moreal · 2023-10-30T11:35:34Z

~~I've run CI in dry-run mode. If the job passes, this pull request can be merged. https://github.com/planetarium/libplanet/actions/runs/6692173135/job/18180817778~~ Passed! ✅

codecov · 2023-10-31T01:24:05Z

Codecov Report

Merging #3468 (51757a5) into main (0e4d8e5) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3468      +/-   ##
==========================================
+ Coverage   79.11%   79.14%   +0.02%     
==========================================
  Files         343      343              
  Lines       11834    11834              
==========================================
+ Hits         9363     9366       +3     
+ Misses       2471     2468       -3

see 2 files with indirect coverage changes

* use ES2022 * add isDigest * WebCrypto Export * yarn upgrade (4.0.1) * Fix typo * Use Typescript ^4.5.0 (due to nanobundle dependancy) * Update Nanobundle 1.6.0 * Use NodeNext (implies EsNext) * Add * use 20 in CI * use lts/* * WebCrypto Shim * Webcrypto Shim 2.0 Electric Boogaloo * Update .github/workflows/yarn.yaml Co-authored-by: Lee Dogeon <[email protected]> * Add rootdir * isDigest Removal * Add engines * Rome ignore. * add * Remove Digest Completely * Add Bencodex * Test * Remove bencodex --------- Co-authored-by: Lee Dogeon <[email protected]>

Akamig added ci & cd Related to CI & CD on Azure Pipelines & GitHub Actions dependencies Pull requests that update a dependency file labels Oct 30, 2023

Akamig requested review from XxshiftxX and moreal October 30, 2023 06:13

Akamig self-assigned this Oct 30, 2023

pull-request-quantifier-deprecated bot added the Medium label Oct 30, 2023

moreal requested a review from tkiapril October 30, 2023 06:29

XxshiftxX previously approved these changes Oct 30, 2023

View reviewed changes

Akamig dismissed XxshiftxX’s stale review via c731668 October 30, 2023 06:29

Akamig force-pushed the update-ts-packages branch 3 times, most recently from 83309ad to 3426d62 Compare October 30, 2023 06:41

moreal reviewed Oct 30, 2023

View reviewed changes

moreal marked this pull request as draft October 30, 2023 06:46

tkiapril changed the title ~~Use Node 20, Update Yarn and some dependancies.~~ Use Node 20, Update Yarn and some dependencies. Oct 30, 2023

Akamig force-pushed the update-ts-packages branch from fab5fde to 7965998 Compare October 30, 2023 06:51

tkiapril previously approved these changes Oct 30, 2023

View reviewed changes

Akamig dismissed tkiapril’s stale review via ee08091 October 30, 2023 06:58

tkiapril previously approved these changes Oct 30, 2023

View reviewed changes

Akamig dismissed tkiapril’s stale review via 10957ae October 30, 2023 07:26

Akamig added 7 commits October 30, 2023 16:27

use ES2022

6b213a4

add isDigest

8cc9cb0

WebCrypto Export

378a3b2

yarn upgrade (4.0.1)

1a90100

Fix typo

9af26a4

Use Typescript ^4.5.0 (due to nanobundle dependancy)

b5ef6fb

Update Nanobundle 1.6.0

a421a0d

Akamig added 2 commits October 30, 2023 16:27

Add rootdir

83612b1

isDigest Removal

a3e4579

Akamig force-pushed the update-ts-packages branch from 10957ae to a3e4579 Compare October 30, 2023 07:28

Add engines

e37ca27

Akamig force-pushed the update-ts-packages branch from fd5b100 to 4df9f60 Compare October 30, 2023 07:47

Rome ignore.

75dd1ed

Akamig force-pushed the update-ts-packages branch from 4df9f60 to 75dd1ed Compare October 30, 2023 07:54

add

e0d5c13

Akamig force-pushed the update-ts-packages branch from e216152 to e0d5c13 Compare October 30, 2023 08:17

Akamig marked this pull request as ready for review October 30, 2023 08:24

Akamig requested a review from tkiapril October 30, 2023 08:25

Remove Digest Completely

86cdf8f

tkiapril previously approved these changes Oct 30, 2023

View reviewed changes

Add Bencodex

84f3847

Akamig dismissed tkiapril’s stale review via 84f3847 October 30, 2023 09:36

tkiapril previously approved these changes Oct 30, 2023

View reviewed changes

Akamig dismissed tkiapril’s stale review via 4638937 October 30, 2023 09:49

Akamig force-pushed the update-ts-packages branch from 4638937 to 7545f05 Compare October 30, 2023 09:55

Test

2271404

Akamig force-pushed the update-ts-packages branch from 7545f05 to 2271404 Compare October 30, 2023 09:57

Remove bencodex

51757a5

tkiapril approved these changes Oct 30, 2023

View reviewed changes

moreal approved these changes Oct 30, 2023

View reviewed changes

Akamig merged commit 8b235a9 into main Oct 31, 2023
23 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Node 20, Update Yarn and some dependencies. #3468

Use Node 20, Update Yarn and some dependencies. #3468

Akamig commented Oct 30, 2023 •

edited

Loading

CLAassistant commented Oct 30, 2023 •

edited

Loading

Akamig commented Oct 30, 2023

moreal Oct 30, 2023 •

edited

Loading

Akamig Oct 30, 2023

Akamig Oct 30, 2023

moreal commented Oct 30, 2023

Akamig commented Oct 30, 2023

Akamig commented Oct 30, 2023 •

edited

Loading

pull-request-quantifier-deprecated bot commented Oct 30, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Oct 30, 2023

Akamig Oct 31, 2023

moreal commented Oct 30, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023

Use Node 20, Update Yarn and some dependencies. #3468

Use Node 20, Update Yarn and some dependencies. #3468

Conversation

Akamig commented Oct 30, 2023 • edited Loading

CLAassistant commented Oct 30, 2023 • edited Loading

Akamig commented Oct 30, 2023

moreal Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

Akamig Oct 30, 2023

Choose a reason for hiding this comment

Akamig Oct 30, 2023

Choose a reason for hiding this comment

moreal commented Oct 30, 2023

Akamig commented Oct 30, 2023

Akamig commented Oct 30, 2023 • edited Loading

pull-request-quantifier-deprecated bot commented Oct 30, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

moreal Oct 30, 2023

Choose a reason for hiding this comment

Akamig Oct 31, 2023

Choose a reason for hiding this comment

moreal commented Oct 30, 2023 • edited Loading

codecov bot commented Oct 31, 2023

Codecov Report

Akamig commented Oct 30, 2023 •

edited

Loading

CLAassistant commented Oct 30, 2023 •

edited

Loading

moreal Oct 30, 2023 •

edited

Loading

Akamig commented Oct 30, 2023 •

edited

Loading

moreal commented Oct 30, 2023 •

edited

Loading