Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New OMP 1.2 Frontend #836

Closed
19 tasks done
NateWr opened this issue Oct 26, 2015 · 2 comments
Closed
19 tasks done

New OMP 1.2 Frontend #836

NateWr opened this issue Oct 26, 2015 · 2 comments
Assignees
@NateWr
Milestone
OMP 1.2

Comments

@NateWr
Copy link
Contributor

NateWr commented Oct 26, 2015

This is just a ticket to help track various tasks related to polishing off the new frontend for 1.2. It will make it easier for me to peg PRs to a specific issue.

  • Ensure header looks good without logo. PR
  • Style catalog entries and sections for full catalog, category, series, new releases and search results. PR
  • Style about and announcement pages. PR
  • Individual book page PR
  • Footer (rough style of what's already there in PR)
  • Get the info pages (for reader, for libraries, etc) styled up. PR
  • Get the tinymce content block working and looking good in the sidebar. PR, PR
  • Figure out a good homepage (features prominent) PR and PR
  • Remove features from category and series pages PR
  • Search results page PR
  • Login page PR
  • Tasks popover PR
  • Primary nav menu dropdowns can go off-page if they're right on the edge of the viewport. PR and PR
  • Primary nav menu dropdowns not accessible on some touch devices (Android) PR
  • Ensure options in Settings > Website > Appearance align with what's actually implemented on the frontend. PR, PR and PR.
  • When no logo is selected, OMP tries to load an ojs_logo.png PR, PR and PR
  • Update all OMP-compatible bloock plugins to new layout structure. PR
  • Ensure AddThis plugin can add social share buttons to book page. See this comment PR
  • Set up a durable HTML scheme for outputting content via hooks on the book page (both right panel and in the main content panel) See PR for a bit of discussion.
@NateWr NateWr added this to the OMP 1.2 milestone Oct 26, 2015
@NateWr NateWr self-assigned this Oct 26, 2015
@NateWr NateWr mentioned this issue Oct 27, 2015
Closed
asmecher added a commit to pkp/omp that referenced this issue Oct 27, 2015
@asmecher
Merge pull request #150 from NateWr/i836_footer_style
e2b1103 
pkp/pkp-lib#836 Styles for new footer setup
asmecher added a commit that referenced this issue Oct 28, 2015
@asmecher
Merge pull request #841 from NateWr/i836_omp_about_announcement_styles
6658307 
#836 Move breadcrumbs template component into pkp-lib and …
asmecher added a commit to pkp/omp that referenced this issue Oct 28, 2015
@asmecher
Merge pull request #151 from NateWr/i836_about_announcement_styles
1240896 
pkp/pkp-lib#836 Update and style the about and announcement page templates
@NateWr NateWr mentioned this issue Oct 28, 2015
Merged
asmecher added a commit that referenced this issue Nov 3, 2015
@asmecher
Merge pull request #860 from NateWr/i836_move_to_lib
a76b83d 
#836 Move some frontend components to pkp-lib
NateWr added a commit to pkp/omp that referenced this issue Nov 3, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Move breadcrumb nav strings to pkp-lib
7c7e230
NateWr added a commit to pkp/omp that referenced this issue Nov 3, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Fix white-space issues
4cb366b
NateWr added a commit to pkp/omp that referenced this issue Nov 3, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Remove OJS-specific styles and tidy a couple things
8d384a9
NateWr added a commit to NateWr/customBlockManager that referenced this issue Nov 4, 2015
@NateWr
pkp/pkp-lib#836 Update template markup for new frontend
dcd107f
asmecher added a commit that referenced this issue Nov 5, 2015
@asmecher
Merge pull request #863 from NateWr/pkp/pkp-lib#836_more_frontend_work
086fac9 
#836 Add search string
NateWr added a commit to pkp/ojs that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Style sidebar blocks
43c6403
NateWr added a commit to pkp/ojs that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Restrict fancy search styles to the header
7397d82
NateWr added a commit to pkp/ojs that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Tidy up login and registration pages
a477f00
NateWr added a commit to pkp/ojs that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Minor style enhancements for tasks popover
0750639
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Style sidebar blocks
de66812
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Use line dividers in monograph lists on small screens
5927a9e
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Left align monograph images on small screens
a46140c
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Restrict fancy search styles to the header
b67b609
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Complete search results page
a9ee77d
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Tidy up the login and registration pages
013c613
NateWr added a commit to pkp/omp that referenced this issue Nov 5, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Minor style enhancements for tasks popover
520419c
asmecher added a commit to pkp/customBlockManager that referenced this issue Nov 5, 2015
@asmecher
Merge pull request #6 from NateWr/pkp/pkp-lib#836_update_block_template
c67c474 
pkp/pkp-lib#836 Update template markup for new frontend
@NateWr
Copy link
Contributor Author

NateWr commented Nov 9, 2015

From Alec regarding the AddThis plugin:

I spent some time fixing the AddThis plugin in OMP master. You can now set it up in the back-end (under "Generic Plugins" in the plugin management interface).

It used to drop into the front end using a hook called "Templates::Catalog::Book::BookInfo::Sharing" but that's gone with the new front end. Feel free to introduce a new hook and change it in plugins/generic/addThis/AddThisPlugin.inc.php to suit. I think this is the method we decided on and it seems OK to me for the moment.

asmecher added a commit to pkp/omp that referenced this issue Nov 10, 2015
@asmecher
Merge pull request #158 from NateWr/i836_markup_block_plugins
830b218 
pkp/pkp-lib#836 Adjust markup for Developed By block plugin
asmecher added a commit to pkp/omp that referenced this issue Nov 10, 2015
@asmecher
Merge pull request #157 from NateWr/i836_book_hooks_and_layout
0434a7a 
pkp/pkp-lib#836 book hooks and layout
asmecher added a commit that referenced this issue Nov 18, 2015
@asmecher
Merge pull request #900 from NateWr/i836_fix_offscreen_menu_dropdowns
3ee6ba6 
#836 Prevent dropdown menus from opening off-screen
NateWr added a commit to pkp/omp that referenced this issue Nov 18, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Prevent dropdown menus from opening off-screen
07a09f5
asmecher added a commit to pkp/omp that referenced this issue Nov 18, 2015
@asmecher
pkp/pkp-lib#836 Submodule update for NateWr/i836_fix_offscreen_menu_d…
e822e70 
…ropdowns
asmecher added a commit to asmecher/omp that referenced this issue Nov 18, 2015
@asmecher
pkp/pkp-lib#836 Submodule update
8b7dbf4
asmecher added a commit to pkp/omp that referenced this issue Nov 18, 2015
@asmecher
Merge pull request #164 from asmecher/i836_homepage_design_2
0de3fab 
pkp/pkp-lib#836 Homepage design
@NateWr NateWr mentioned this issue Nov 23, 2015
Closed
7 tasks
asmecher added a commit that referenced this issue Nov 24, 2015
@asmecher
Merge pull request #916 from NateWr/i836_fix_app_logo_reference
a109067 
#836 Use common name for app logo so it works for any app
NateWr added a commit to pkp/ojs that referenced this issue Nov 24, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Rename app logo to be the same as OMP's
d5c343e
NateWr added a commit to pkp/omp that referenced this issue Nov 24, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Rename app logo to be the same as OJS's
066c4e0
asmecher added a commit to pkp/omp that referenced this issue Nov 24, 2015
@asmecher
Merge pull request #166 from NateWr/i836_revert_to_old_featured_style
043d385 
pkp/pkp-lib#836 Show more details of featured/new books on the homepage
@NateWr NateWr closed this as completed Nov 25, 2015
@asmecher
Copy link
Member

That was a big one! Congrats.

asmecher added a commit that referenced this issue Nov 30, 2015
@asmecher
Merge pull request #922 from NateWr/i836_settings_appearance_form
6a892e8 
#836 settings appearance form
asmecher added a commit to pkp/ojs that referenced this issue Nov 30, 2015
@asmecher
Merge pull request #676 from NateWr/i836_settings_appearance_form
97c6357 
pkp/pkp-lib#836 settings appearance form
NateWr added a commit to pkp/omp that referenced this issue Nov 30, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Restructure appearance form settings
a2993fb
NateWr added a commit to pkp/omp that referenced this issue Nov 30, 2015
@NateWr @asmecher
pkp/pkp-lib#836 Fix typo
4fde93f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
None yet
Projects
None yet
Milestone
OMP 1.2
Development

No branches or pull requests
2 participants
@asmecher @NateWr