From a477f00c476b5f246be896faaf70b80e62e320d8 Mon Sep 17 00:00:00 2001
From: Nate Wright <natew@notthisway.com>
Date: Wed, 4 Nov 2015 15:13:58 +0000
Subject: [PATCH] pkp/pkp-lib#836 Tidy up login and registration pages

---
 plugins/themes/default/styles/components.less | 94 +++++++++++++++++--
 .../themes/default/styles/pages/login.less    |  6 +-
 .../themes/default/styles/pages/register.less | 41 --------
 3 files changed, 89 insertions(+), 52 deletions(-)

diff --git a/plugins/themes/default/styles/components.less b/plugins/themes/default/styles/components.less
index 87d668da17b..94a7114ca75 100644
--- a/plugins/themes/default/styles/components.less
+++ b/plugins/themes/default/styles/components.less
@@ -66,20 +66,20 @@
 
 		> li {
 			position: relative;
-			padding-bottom: @double; // Contain errors
+			padding-bottom: @triple; // Contain errors
 
 			// Nest so we don't grab .error class attached to li
 			.error {
 				position: absolute;
 				left: 0.5em; // Sit off the rounded edge of input fields
-				bottom: -3px; // Sit on the bottom line of the input field above
-				padding: 4px 0.5em; // Keep it tight so it doesn't bleed into next field
+				bottom: 11px; // Sit on the bottom line of the input field above
+				padding: 0 0.5em; // Keep it tight so it doesn't bleed into next field
 				background: @no;
-				border-bottom-left-radius: 2px;
-				border-bottom-right-radius: 2px;
-				font-size: 12px; // Special case for tiny text
-				line-height: 16px;
-				font-weight: 700;
+				border-bottom-left-radius: @radius;
+				border-bottom-right-radius: @radius;
+				font-size: @font-sml;
+				line-height: @double;
+				font-weight: @bold;
 				color: #fff;
 			}
 		}
@@ -133,6 +133,84 @@
 			max-width: 20em;
 		}
 	}
+
+	// Tag-it component
+	// @todo This just duplicates some styles from pkp-lib. We can probably
+	//  find a better way to share styles after beta, or move this to somewhere
+	//  more appropriate in the theme.
+	.tagit {
+		&:extend(.pkp_unstyled_list);
+		&:extend(.pkp_form input[type="text"]);
+		.pkp_helpers_clear();
+
+		// overwrite text field styles
+		max-width: 100%;
+		height: auto;
+
+		> li {
+			display: inline-block;
+
+			&.tagit-choice {
+				margin-right: 0.5em;
+				padding-left: 0.5em;
+				background: @bg;
+				border-radius: @radius;
+				line-height: @double;
+			}
+		}
+
+		input[type="text"] {
+			display: inline-block;
+			border: none;
+			width: inherit;
+			line-height: 30px;
+			height: 30px;
+			vertical-align: top;
+			padding: 0 0.5em;
+		}
+	}
+
+	.tagit-close {
+		padding: 0 0.5em;
+		color: @no;
+	}
+}
+
+// Auto-complete selection fields for tagit component (not nested in .pkp_form)
+.ui-autocomplete {
+	&:extend(.pkp_unstyled_list);
+	width: 20em;
+	padding: 2px;
+	border-radius: @radius;
+	background: @bg-base;
+
+	&:before {
+		content: '';
+		position: absolute;
+		top: -@half;
+		left: 1em;
+		width: 0;
+		height: 0;
+		color: @bg-base;
+		border-bottom: @half solid;
+		border-right: @half solid transparent;
+		border-left: @half solid transparent;
+		vertical-align: middle;
+	}
+
+	> li {
+		padding: @half;
+		font-size: @font-sml;
+		line-height: @line-sml;
+		color: #fff;
+		cursor: pointer;
+
+		&:hover,
+		&:focus {
+			background: @bg;
+			color: @text;
+		}
+	}
 }
 
 // Access legend
diff --git a/plugins/themes/default/styles/pages/login.less b/plugins/themes/default/styles/pages/login.less
index 5a9d3f7806f..62786f4eb91 100644
--- a/plugins/themes/default/styles/pages/login.less
+++ b/plugins/themes/default/styles/pages/login.less
@@ -27,7 +27,7 @@
 
 			a {
 				float: right;
-				font-size: 12px;
+				font-size: @font-sml;
 				font-style: normal;
 			}
 		}
@@ -51,8 +51,8 @@
 
 		a {
 			float: right;
-			font-size: 12px;
-			line-height: @double;
+			font-size: @font-sml;
+			line-height: @triple;
 			margin-right: 1em;
 		}
 	}
diff --git a/plugins/themes/default/styles/pages/register.less b/plugins/themes/default/styles/pages/register.less
index 3872e2589d7..75ee92c4868 100644
--- a/plugins/themes/default/styles/pages/register.less
+++ b/plugins/themes/default/styles/pages/register.less
@@ -78,47 +78,6 @@
 		}
 	}
 
-	// Tag-it component
-	// @todo This just duplicates some styles from pkp-lib. We can probably
-	//  find a better way to share styles after beta, or move this to somewhere
-	//  more appropriate in the theme.
-	.tagit {
-		&:extend(.pkp_unstyled_list);
-		&:extend(.pkp_form input[type="text"]);
-		.pkp_helpers_clear();
-
-		// overwrite text field styles
-		max-width: 100%;
-		height: auto;
-
-		> li {
-			display: inline-block;
-
-			&.tagit-choice {
-				margin-right: 0.5em;
-				padding-left: 0.5em;
-				background: @bg;
-				border-radius: @radius;
-				line-height: @double - @half;
-			}
-		}
-
-		input[type="text"] {
-			display: inline-block;
-			border: none;
-			width: inherit;
-			line-height: 30px;
-			height: 30px;
-			vertical-align: top;
-			padding: 0 0.5em;
-		}
-	}
-
-	.tagit-close {
-		padding: 0 0.5em;
-		color: @no;
-	}
-
 	@media(min-width: @screen-tablet) {
 
 		.identity li {