-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mc.exe could be windmc.exe #1276
Comments
Thanks @Kreijstal. @dgreatwood handles our recent Windows port. He is a very brave man to have successfully pursued that undertaking. I'm sure he'll look into this. |
Thank you Just a comment: The syntax is a bit different.
|
Thank you. If you'd like to propose a PR, it will speed things up. @dgreatwood and I will review. Otherwise it might take a while for @dgreatwood to fix it. |
Thanks @Kreijstal for pointing that out. I will have a look at this when I get the chance. If you would like to try a PR, as you may already have seen the file src/meson.build is the one that causes mc.exe to be invoked. To deal with mc.exe vs. windmc.exe, you can see how it deals with the similar case of rc.exe vs. windres.exe. Plus deal with syntax adjustments as you said. There might also need to be an update to gccsetup.ps1 to install windmc.exe and place it on the path if it is not installed by default along with gccsetup.ps1's existing gcc install. Or if not I'll look at this eventually myself. Thanks again! |
Hi @Kreijstal, I took a quick look at this. Currently mc.exe supports both "manifest" files (XML format) and "message test files", whereas, as far as I can make out windmc.exe supports solely "message text files". The two file formats are quite different, e.g.
Sure enough, when I feed Pistache's logging manifest file, pist_winlog.man, into windmc.exe, it throws an error on the first line. Unless you know of some other way to deal with the manifest file, I think we're stuck using mc.exe for now. Also of note - mc.exe supports the command line "-um" option, which means "Generate User Mode logging macros". I don't see an equivalent option on windmc.exe; not surprising since I presume this would be a logging-manifest-specific option. LMK any additional thoughts... |
pistache/src/meson.build
Line 127 in 11738a5
When compiling with mingw from linux or from msys2, mingw provides windmc.exe not mc.exe, maybe look for it to accept non MSVC toolchains?
The text was updated successfully, but these errors were encountered: