Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]? Excessive logging during build: 'Failed to find any user-provided fetch implementation' message in Pinecone SDK 3.0.1 #254

Closed
2 tasks done
ElectricCodeGuy opened this issue Aug 23, 2024 · 7 comments
Assignees
Labels
bug Something isn't working status:needs-triage An issue that needs to be triaged by the Pinecone team

Comments

@ElectricCodeGuy
Copy link

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing Github issues and Community Forum, and I could not find an existing post for this bug

Describe the bug
After updating the Pinecone SDK from version v2.2.2 to 3.0.1, the build process is logging the message "Failed to find any user-provided fetch implementation. Using global fetch implementation." This message was not present in the previous version and is being logged during the Next.js build process. I do NOT use any edge runtime. The issue occurs both during local builds and in the Vercel logging when deployed to the website.

Error information
This is not an error per se, but a console log message that appears during the build process:
"Failed to find any user-provided fetch implementation. Using global fetch implementation."

The message is coming from the file:
/node_modules/@pinecone-database/pinecone/dist/utils/fetch.js

Steps to reproduce the issue locally

  1. Update @pinecone-database/pinecone to version 3.0.1
  2. Run npm run build or next build in a Next.js project that uses Pinecone
  3. Observe the console output during the build process
  4. Deploy the project to Vercel and observe the same message in the Vercel logs

Environment

  • OS and version: Ubuntu 22.04.4 LTS
  • Node version: v20.14.0
  • Typescript SDK version: @pinecone-database/pinecone 3.0.1
  • Next.js version: 14.2.6

Additional context
This message appears to be a new console.log statement added in the Pinecone SDK version 3.0.1. While it's not causing any apparent functionality issues, it's creating noise in the build output and could potentially be confusing for developers.

The message is logged when the SDK falls back to using the global fetch implementation. This behavior might be intentional, but the logging of this message during every build could be considered excessive.

The issue is not limited to local development environments but also occurs in production deployments on Vercel, potentially cluttering logs and making it harder to identify actual issues or errors.

@ElectricCodeGuy ElectricCodeGuy added the bug Something isn't working label Aug 23, 2024
@github-actions github-actions bot added the status:needs-triage An issue that needs to be triaged by the Pinecone team label Aug 23, 2024
@aulorbe
Copy link
Contributor

aulorbe commented Aug 27, 2024

Hi @ElectricCodeGuy! Thanks for bringing this to our attention. We will reduce the noise in the logs as soon as we have time.

@aulorbe aulorbe self-assigned this Aug 27, 2024
@aqizzz
Copy link

aqizzz commented Sep 4, 2024

Same issue

@trevoruptain
Copy link

Same issue, causes a lot of logging clutter

@samueldashadrach
Copy link

samueldashadrach commented Sep 10, 2024

+1, same issue. Is there anyway to to disable logs. Makes the entire console unusable.

image

@aulorbe
Copy link
Contributor

aulorbe commented Sep 11, 2024

Just merged this PR which closes this issue. Will issue patch release shortly!

@aulorbe
Copy link
Contributor

aulorbe commented Sep 11, 2024

Released! Pull down v3.0.3 https://github.com/pinecone-io/pinecone-ts-client/releases/tag/v3.0.3 to get the latest code.

@christophemarois
Copy link

For people unable to upgrade to the fix above just yet, this will fix the noisy output:

const pc = new Pinecone({ fetchApi: fetch })

@austin-denoble austin-denoble mentioned this issue Sep 18, 2024
7 tasks
@aulorbe aulorbe closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:needs-triage An issue that needs to be triaged by the Pinecone team
Projects
None yet
Development

No branches or pull requests

6 participants