Review from Eli Miller

[Yousuf28]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded. Remember that this is a community we
  build together 💪.

To get started, comment below with an introduction of yourself and tell us about what you do with this community.

[Yousuf28]

• "You are calling @import and @importFrom in several places. Best practice is to call all of these at once in the package documentation file."

1. ImportFrom used in initSENDFunctions.R file and NAMESPACE file. NAMESPACE file edited by roxygen package which added importFrom from initSENDFunction.R file. So basically importFrom used in only one R file.

[Yousuf28]

• "You should add BioCelerate to the DESCRIPTION file as the copyright holder. This is required if you're submitting to CRAN."

2. BioCelerate added in Description file
   link

[Yousuf28]

• "In several places you're using print to send messages to the console. I would recommend to use message or warning to allow people to suppress messages if they need to."

3. print function- Here is the file list where print used.

print function in controlfiltering_shiny.R file mainly print out selected input from shiny sidebar (date, study design, species, strain, sex and etc.) and control animal table. Print commented out inside function, and two print replaced with message function.
Those option (date, study design, species, strain, sex and etc.) now printing from sendDashboard_shiny.R file with print function used once.
Other file that have print function populateDBFunction.R which print column names and other information. Not sure I should comment that out.
So basically if user run shiny app calling execSendDashboard function this will print user input (date, study design, species, strain, sex and etc.) in console and dbCreateSchema() function print information about all the table like column name.

[Yousuf28]

• "This might be my hot take but I would remove the return calls where they aren't being used to set an explicitly stop the evaluation of a function."

4. Main functions of the package written by Bo Larsen and he consistently used return function at the end of each function.
   we can keep or remove the return function at the end of fucntion, either is fine.
   In other place return is used explicitly in condition.

[wangw106]

I removed those Return statements if not used explicitly in condition.

[Yousuf28]

• "You're setting a lot of variables to NULL in a few files. You should update this to a single call to globalVariables."

5. NULL replaced with globalVariable as suggested.