-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build tools for PMA v5 #105
Comments
Folder StructureYourTheme theme must respect the folders structure of phpMyAdmin. ├── node_modules
├── themes
│ └── YourTheme
│ ├── css/
│ ├── img/
│ ├── jquery/
│ ├── scss/
│ ├── screen.png
│ └── theme.json
├── package.json
└── yarn.lock DependeciesAll deps are updated to the latest version.
BuildingTo build the theme you must have Node, Yarn and Git installed.
# production, minified files
yarn run build
# development
yarn run build:dev
Publish themeFollow instructions: https://github.com/phpmyadmin/themes#updatingcreating-themes |
Hello @adorade |
Hi @williamdes |
I have some questions to ask before I create a new pull request. This will help me understand some details better. PMA v5.2.1 relies on I will check the compatibility of the latest versions of I plan to include a new section called How to build a theme in the README file, right before the Releasing section. Which option do you think is better: creating a separate file named I would appreciate any advice or recommendation. |
@adorade Thanks! That would be very helpful. We have a bit of duplicated documentation (in https://github.com/phpmyadmin/themes#updatingcreating-themes and https://github.com/phpmyadmin/phpmyadmin/blob/master/docs/themes.rst#creating-custom-theme) and I am a big fan of reducing duplication so we only have one true source. I'd personally prefer to have that in the themes repository, and then I can write a small paragraph in the "phpmyadmin" repository linking to that. So to answer your question, my personal preference is to make a new file in the themes repository, and it doesn't need to be all capital letters so I think "Creating-a-theme.md" would be a great filename. |
Having duplicate documentation can occasionally cause confusion, particularly if one of the sources is not up-to-date. I believe that all details pertaining to the creation of a PMA theme ought to be consolidated within the A preferable approach would be to add new sections containing all the essential information about: 1. Build toolsThis section covers build tools (webpack configuration), dependencies, and the organization of the folder structure. 2. Theme configurationInstructions on how to configure a theme using 3. How to create a themeGuidance on creating 4. Testing ProceduresCurrently, the sole method to test a theme is by navigating through the PMA interface. One must click on every link and button to ensure no elements have been overlooked. 5. How to uploadHow to upload it to the "phpmyadmin/themes" repository. 6. ReleasingReleasing the new theme. The step-by-step process described above should be simple for the theme developer, whether a novice or an expert, as well as for the one who reviews and tests the theme. |
@williamdes
Thanks for giving my BooDark theme as an example. In the following days I will update the theme, something minor, and I will also update the build tools. My theme is based on the Bootstrap theme, not pmahomme. Supports PMA v5.2 with Bootstrap v5.2.3.
Helpful for those who want to build a new theme, continued from #104
Keep in touch! 💪
The text was updated successfully, but these errors were encountered: