Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Signature corruption on adding new import #4

Open
greenozon opened this issue Apr 28, 2018 · 2 comments
Open

Digital Signature corruption on adding new import #4

greenozon opened this issue Apr 28, 2018 · 2 comments
Assignees
Labels
bug non-critical Non-critical bug

Comments

@greenozon
Copy link

greenozon commented Apr 28, 2018

Info

Once you add a new dll into Import Section the existing "Digital Signatures" tab stops to show in File Properties

Details

Open up your exe with Digital Signature present
go to Directories -> Import Directory
Right click on dll list, click "Add Imports..."
Fill in

  • new section name
  • Dll name
  • API name

click OK
Save your file

open up File properties in explorer - "DIgital SIgnatures" section is gone.

Here is a visual comparison of added section data (left) and old certificate data that was corrupted (right)

http://prntscr.com/jbcdnf

Tool used - http://prntscr.com/jbcee0

@upiter
Copy link
Collaborator

upiter commented Apr 30, 2018

Bug Status

Workaround

  • Remove certificates before any modification

Bug fix Progress

  • Added to non-critical bug list
  • Possible bug fix date: not assigned

Bug fix Suggestion

  • Check for presence of digital signatures (certificate info)
  • Warn in case of modification and propose to remove digital signature from file
  • Add an option to automatically remove any digital signatures from file in case of any modification

@upiter upiter added bug non-critical Non-critical bug labels Apr 30, 2018
@greenozon
Copy link
Author

Thank you for accepting the issue,
I'd like to say that Workaround might be good for some cases, but thats not my case.
As far as I see certificate is embedded into executable as overlay, maybe thats the reason of mis-behavior?

Anyway, digital certs removal as an option is already present, so it might be done for sure by hands,
but this issue goal is to automatically take into account the fact of presence of digital cert in case when one is adding new import...
is it doable?
I tried some other tools - all are corrupting cert in this scenario, so that might be a magic feature successfully performed by this grand tool

PS I understand that purpose of cert is to ensure the input file is genuine, but... in some cases this is still an option to leave it as is.
so ideally would be to ask user in twofold-
a) remove cert
b) leave it and
do the job

@upiter upiter self-assigned this Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug non-critical Non-critical bug
Projects
None yet
Development

No branches or pull requests

2 participants