Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: rely on matplotlib-base instead of pinning matplotlib <= 3.9 #252

Open
tangkong opened this issue Aug 26, 2024 · 4 comments
Open

BLD: rely on matplotlib-base instead of pinning matplotlib <= 3.9 #252

tangkong opened this issue Aug 26, 2024 · 4 comments

Comments

@tangkong
Copy link
Contributor

Expected Behavior

We shouldn't pin dependencies for extended amounts of time.

Current Behavior

We pin matplotlib

Possible Solution

We should depend on matplotib-base

Steps to Reproduce (for bugs)

N/A

Context

#251

Your Environment

pcds-5.8.4, for now

@ZLLentz
Copy link
Member

ZLLentz commented Aug 27, 2024

Note that this pin creates a warning in the pcds-envs build because somehow I have a matplotlib above 3.9 without the pyside support, which is confusing in itself

@tangkong
Copy link
Contributor Author

This was closed by #251 , as far as atef is concerned.

Is the missing pyside support due to the use of matplotlib-base?

@ZLLentz
Copy link
Member

ZLLentz commented Aug 27, 2024

Sorry, maybe I should have made a new ticket to track this
But what I mean is that anything in requirements.txt is picked up by pip check, so this line gives a warning if a newer matplotlib is installed:

matplotlib<=3.9.0

@ZLLentz
Copy link
Member

ZLLentz commented Aug 27, 2024

The identity of the missing pyside support is unknown to me, except that the build that the solver picks doesn't require pyside (all the newest builds do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ZLLentz @tangkong and others