Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of "new file" dialog show "atef welcome" #201

Open
klauer opened this issue Aug 31, 2023 · 3 comments · Fixed by #213
Open

Instead of "new file" dialog show "atef welcome" #201

klauer opened this issue Aug 31, 2023 · 3 comments · Fixed by #213

Comments

@klauer
Copy link
Contributor

klauer commented Aug 31, 2023

Current Behavior

If I open a config through atef config test.json, the welcome dialog doesn't show up.
Then if I expect to make a new config, the dialog is less fancy (and perhaps unfamiliar for users)

Possible Solution

It'd make sense if "New file" just took you to the welcome page, I think

Context

Nice welcome dialog:
image

Less nice new file dialog:
image

@klauer
Copy link
Contributor Author

klauer commented Oct 31, 2023

Was this actually closed? I still see the old dialog pop up when clicking "File -> New":
image

@klauer klauer reopened this Oct 31, 2023
@tangkong
Copy link
Contributor

I guess I didn't see a reason to remove this dialog entirely, rather I added the ability to open the welcome tab and let the "new file" menu action explicitly guide users through opening a new file. (rather than bring up a tab with a growing number of other options)

Do you think this dialog is bad enough that it's actively confusing? I can take it out if so, I just figured it wasn't hurting anyone

@klauer
Copy link
Contributor Author

klauer commented Oct 31, 2023

I just find the welcome dialog to be that much better and see no point in this minimal dialog

Your call, of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants