Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplication of CHEBI terms IN FOBI namespace #3

Open
kaiiam opened this issue Feb 1, 2021 · 1 comment
Open

Possible duplication of CHEBI terms IN FOBI namespace #3

kaiiam opened this issue Feb 1, 2021 · 1 comment

Comments

@kaiiam
Copy link

kaiiam commented Feb 1, 2021

Hello FOBI development team, as I'd mentioned to @ddooley I was looking over FOBI the other day and I noticed that there are some examples of FOBI terms which might be duplicative of existing CHEBI terms.

For example FOBI:Fatty acid esters seems like it might be a duplication of CHEBI:fatty acid ester. Just for reference it's encouraged practice within OBO ontologies, (obo principal 5) to reuse existing terms when possible. If so perhaps you could import such chebi terms and then insert them into your existing hierarchy? I can see the need to have a slightly different top level hierarchy than CHEBI, but if there are correspondences with CHEBI then perhaps you could be reusing CHEBI terms themselves?

Just thought I'd point it out, hope it's helpful and perhaps something to consider moving forward.

Cheers,
Kai

@ddooley
Copy link
Collaborator

ddooley commented Apr 14, 2021

I'll note that Pol and I set up a big CHEBI import file https://github.com/pcastellanoescuder/FoodBiomarkerOntology/blob/master/imports/chebi_import.owl that brings alot of biomarker chemicals into FOBI, so well aware of principle 5. But Pol, I recall the remaining chemicals were problematic in some sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants