Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash app, theme, android manifest #100

Open
jagerlipton opened this issue Oct 7, 2016 · 6 comments
Open

Crash app, theme, android manifest #100

jagerlipton opened this issue Oct 7, 2016 · 6 comments

Comments

@jagerlipton
Copy link

Crash app with any android theme

 <activity android:name="net.rdrei.android.dirchooser.DirectoryChooserActivity"
            android:theme="@android:style/Theme.DeviceDefault"
            />

No crash with my theme

<activity android:name="net.rdrei.android.dirchooser.DirectoryChooserActivity"
            android:theme="@style/DialogTheme"
            />
@BoolHak
Copy link

BoolHak commented Jan 9, 2017

add this to the application tag:
tools:replace="android:theme"

@artm
Copy link

artm commented Jul 13, 2017

What problem does that line solve?

@jagerlipton
Copy link
Author

jagerlipton commented Jul 14, 2017

What problem does that line solve?

This answer does not solve my question. The library does not accept standard android theme (. "Tool-replace" has been used.

@ParkerK
Copy link
Contributor

ParkerK commented Jan 26, 2018

I can confirm @passy AND @BraisGabin fixed this in commit: 25b5c12, as building the library locally I no longer have this issue. Thank you!

@Adsama94
Copy link

I was having trouble adding this dependency along with the same manifest warnings. Here's what I did to fix it -

In my app manifest I added the following in the application tag -

tools:replace="android:theme"> <activity android:name="net.rdrei.android.dirchooser.DirectoryChooserActivity" android:theme="@style/DirectoryChooserTheme"/>

In my app level gradle file I added these dependencies -

implementation 'net.rdrei.android.dirchooser:library:3.2@aar' implementation 'com.gu:option:1.3'

In my project level gradle file I added this inside the allprojects block -

maven { url 'http://guardian.github.com/maven/repo-releases' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants