Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no deviceToken, count is never decremented fully, and the PushStatus never marked success/fail #54

Open
jeacott1 opened this issue Feb 7, 2017 · 0 comments

Comments

@jeacott1
Copy link
Contributor

jeacott1 commented Feb 7, 2017

if I have no deviceToken assigned, and send a push to that Installation,
then in PushAdapterUtils.classifyInstallations:

// No deviceToken, ignore
if (!installation.deviceToken) {
continue;
}

completely shortcuts any attempted execution of push to these devices.

this is fine, but because the push is never sent, no response from the push service can decrement the count,
so it never completes, and PushStatus is left in a 'running' state with outstanding count equal to the number of null deviceToken records.

somewhere here, this needs to either drop the total count, or decrement the oustanding count,
or just drop the if/continue altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant