Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text extraction #6

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Text extraction #6

merged 2 commits into from
Feb 10, 2022

Conversation

Uinelj
Copy link
Member

@Uinelj Uinelj commented Feb 9, 2022

Adds an operation that produces a OSCAR Schema v1 corpus from OSCAR Schema v2 corpus.

The PR is missing an integration test to be ready for merging.

@Uinelj Uinelj linked an issue Feb 9, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #6 (3f73ac2) into dev (4c51940) will increase coverage by 7.43%.
The diff coverage is 85.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev       #6      +/-   ##
==========================================
+ Coverage   56.90%   64.33%   +7.43%     
==========================================
  Files          11       12       +1     
  Lines         297      401     +104     
==========================================
+ Hits          169      258      +89     
- Misses        128      143      +15     
Impacted Files Coverage Δ
src/cli.rs 0.00% <0.00%> (ø)
src/error.rs 0.00% <ø> (ø)
src/main.rs 0.00% <ø> (ø)
src/extract_text.rs 82.05% <82.05%> (ø)
src/impls/oscar_doc.rs 86.36% <89.06%> (+86.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c51940...3f73ac2. Read the comment docs.

also changes behaviour of extract which now expects a file path on `dst`
@Uinelj Uinelj marked this pull request as ready for review February 10, 2022 16:18
@Uinelj Uinelj merged commit dcc3aad into dev Feb 10, 2022
@Uinelj Uinelj deleted the dev-extract-text branch February 10, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: content/metadata file splitter
1 participant