Is there a reason the response class checks for a Buffer specifically and not an instance of Uint8Array?

[andrew-connell]

As per title. I'm still on v5 but v6 has basically the same code.
in getDataType in the Response class - Instead of

if (Buffer.isBuffer(content)) {
    return 'buffer';
}

it works much better like

if (content instanceof Uint8Array) {
    return 'buffer';
}

Because this will handle Uint8Arrays without having to convert to a Buffer. In my limited testing it works perfectly with this tiny change.
The use case being puppeteer having changed output to to Uint8Array instead of Buffer.

You can do Buffer.from(Uint8Array) but that seems very inefficient

[RomainLanz]

Hey @andrew-connell! 👋🏻

Can you make a PR with a test?

[andrew-connell]

Well despite being a dev for decades, I've never done that before. I've created a pull request now, let me know if I did it right.
adonisjs/http-server#97