diff --git a/pkg/cloudprovider/providers/oci/instances.go b/pkg/cloudprovider/providers/oci/instances.go index 51ef20b42a..c8ae9d35f0 100644 --- a/pkg/cloudprovider/providers/oci/instances.go +++ b/pkg/cloudprovider/providers/oci/instances.go @@ -100,7 +100,7 @@ func (cp *CloudProvider) extractNodeAddresses(ctx context.Context, instanceID st secondaryVnic, err := cp.client.Compute().GetSecondaryVNICForInstance(ctx, compartmentID, instanceID) if err != nil { - return nil, errors.Wrap(err, "GetSecondaryVNICForInstance") + return addresses, nil } if secondaryVnic == nil { @@ -124,6 +124,7 @@ func (cp *CloudProvider) extractNodeAddresses(ctx context.Context, instanceID st addresses = append(addresses, api.NodeAddress{Type: api.NodeExternalIP, Address: ip.String()}) } } + // Changing this can have wide reaching impact. // // if vnic.HostnameLabel != nil && *vnic.HostnameLabel != "" { diff --git a/pkg/cloudprovider/providers/oci/node_info_controller.go b/pkg/cloudprovider/providers/oci/node_info_controller.go index 5505569c23..69c9b00f14 100644 --- a/pkg/cloudprovider/providers/oci/node_info_controller.go +++ b/pkg/cloudprovider/providers/oci/node_info_controller.go @@ -41,10 +41,9 @@ import ( // metadata labeling for placement info const ( - FaultDomainLabel = "oci.oraclecloud.com/fault-domain" - CompartmentIDAnnotation = "oci.oraclecloud.com/compartment-id" - OpenShiftNodeIdentifierLabel = "node.openshift.io/os_id" - timeout = 10 * time.Second + FaultDomainLabel = "oci.oraclecloud.com/fault-domain" + CompartmentIDAnnotation = "oci.oraclecloud.com/compartment-id" + timeout = 10 * time.Second ) // NodeInfoController helps compute workers in the cluster