Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Conformance Testsuite #956

Open
sdasgup3 opened this issue Jan 23, 2023 · 5 comments
Open

Develop Conformance Testsuite #956

sdasgup3 opened this issue Jan 23, 2023 · 5 comments

Comments

@sdasgup3
Copy link
Member

This is about a test suite that consumers can plug into and run on their hardware. The golden results of the tests are expected to be vetted by the reference implementation of the specification.

@bhack
Copy link

bhack commented Jan 25, 2023

What is supposed to be tested here?
I am asking this just to understand the scope in the perspective with the thread we have at openxla/community#33 (comment)

@bhack
Copy link

bhack commented Feb 13, 2023

Any comment on my point?

@sdasgup3
Copy link
Member Author

Hi @bhack
Thanks for sharing the links and sorry for the delay in replying.

The aim of the conformance suite is to comprehensively cover the StableHLO specification. An important milestone towards that are the tests for the reference implementation which exhaustively covers the behavior of individual ops.. Currently we are focusing on the static shaped opset.

In the future, we are planning to also introduce support for dynamic shapes (#8) and "Quantization" category of StableHLO operations (#588 #530 #531) and the test suite should evolve accordingly to accommodate the augmented specification. The exact details are work in progress.

@bhack
Copy link

bhack commented Feb 14, 2023

Yes I understand this. I was only a little bit more confused by

consumers can plug into and run on their hardware

Do we suppose to interface with compiler and runtime (and so the hardware) using openxla-pjrt?

As it seems there we expect to interact with not fully (StableHLO program) conformant compilers/runtimes it is going to impact that topic in the openxla-pjrt-plugin API design when interact with frontends (especially if we want to not just fail fast on the fronted side).

It seems to me that there a space to strictly co-design this.

@sdasgup3
Copy link
Member Author

Do we suppose to interface with compiler and runtime (and so the hardware) using openxla-pjrt?

Interfacing using openxla-pjrt could certainly be a favourable option, but needs further exploration.
At the moment the priority of conformance test-suite is reduced in favour of 2023 StableHLO milestones roadmap.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants