You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the spec, there are several places like this, where we use constant(some_constant_value, element_type(result)) to produce a constant of type element_type(result). However, this should not be confused with the StableHLO constant op which only produces constant with tensor types.
IMO, to avoid confusion, we should introduce a separate meta function, under the spec section "function on values", as follows.
* `constant(x: Value, type: TensorElementType | QuantizedTensorElementType)` is
defined on constant inputs and returns a constant of type `TensorElementType` or
`QuantizedTensorElementType`.
The text was updated successfully, but these errors were encountered:
"However, this should not be confused with the StableHLO constant op which only produces constant with tensor types". I am a bit confused because #1647 (the discussion in which seems to have prompted creating this ticket) changes ConstantOp to support constants with quantized tensor type as well?
burmako
changed the title
Clarify the use of constant(value, element_type) in spec
Audit the use of constant(value, element_type) for quantized types
Jul 17, 2023
In the spec, there are several places like this, where we use
constant(some_constant_value, element_type(result))
to produce a constant of typeelement_type(result)
. However, this should not be confused with the StableHLO constant op which only produces constant with tensor types.IMO, to avoid confusion, we should introduce a separate meta function, under the spec section "function on values", as follows.
The text was updated successfully, but these errors were encountered: