From 5cd228d87a85cd8ab7bec05951094774a683944c Mon Sep 17 00:00:00 2001 From: Christopher Bate Date: Tue, 3 Sep 2024 17:43:24 -0600 Subject: [PATCH] [cmake] Remove dependence on LLVM 'Core' component in the CMake build (#2522) This change removes two spurious 'LINK_COMPONENTS Core' declarations in the CMake build. Depending on the 'Core' component indicates that the libraries depend on the code under 'llvm-project/llvm/lib/IR' (e.g. 'LLVMCore' library), which is not true for the StablehloLinalgTransforms and StablehloTOSATransforms libraries. --- stablehlo/conversions/linalg/transforms/CMakeLists.txt | 3 --- stablehlo/conversions/tosa/transforms/CMakeLists.txt | 3 --- 2 files changed, 6 deletions(-) diff --git a/stablehlo/conversions/linalg/transforms/CMakeLists.txt b/stablehlo/conversions/linalg/transforms/CMakeLists.txt index f28dd6bf177..359dad11bb4 100644 --- a/stablehlo/conversions/linalg/transforms/CMakeLists.txt +++ b/stablehlo/conversions/linalg/transforms/CMakeLists.txt @@ -30,9 +30,6 @@ add_mlir_library(StablehloLinalgTransforms StablehloOpsIncGen StablehloLinalgTransformsPassIncGen - LINK_COMPONENTS - Core - LINK_LIBS PUBLIC ChloOps StablehloBase diff --git a/stablehlo/conversions/tosa/transforms/CMakeLists.txt b/stablehlo/conversions/tosa/transforms/CMakeLists.txt index 2109c298ce8..eeb49ee95fe 100644 --- a/stablehlo/conversions/tosa/transforms/CMakeLists.txt +++ b/stablehlo/conversions/tosa/transforms/CMakeLists.txt @@ -33,9 +33,6 @@ add_mlir_library(StablehloTOSATransforms StablehloTOSAPDLLPatternsIncGen StablehloOpsIncGen - LINK_COMPONENTS - Core - LINK_LIBS PUBLIC MLIRIR MLIRPass