From 864d0a71389a83878115848739599110abf8db29 Mon Sep 17 00:00:00 2001
From: Lun-Kai Hsu <kaikaikai1219@gmail.com>
Date: Thu, 23 Jan 2025 11:27:24 -0800
Subject: [PATCH] [fix] modular setup macro padding (#1252)

* fix modular setup macro padding

* cleanup

* fix
---
 extensions/algebra/moduli-setup/src/lib.rs | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/extensions/algebra/moduli-setup/src/lib.rs b/extensions/algebra/moduli-setup/src/lib.rs
index f98b74cd7..b590dd6c1 100644
--- a/extensions/algebra/moduli-setup/src/lib.rs
+++ b/extensions/algebra/moduli-setup/src/lib.rs
@@ -63,15 +63,17 @@ pub fn moduli_declare(input: TokenStream) -> TokenStream {
         let modulus = modulus.expect("modulus parameter is required");
         let modulus_bytes = string_to_bytes(&modulus);
         let mut limbs = modulus_bytes.len();
+        let mut block_size = 32;
 
-        if limbs < 32 {
+        if limbs <= 32 {
             limbs = 32;
-            proc_macro::Diagnostic::new(proc_macro::Level::Warning, "`limbs` has been set to 32 because it was too small; this is going to be changed once we support more flexible reads").emit();
+        } else if limbs <= 48 {
+            limbs = 48;
+            block_size = 16;
+        } else {
+            panic!("limbs must be at most 48");
         }
 
-        // The largest power of two so that at most 10% of all space is wasted
-        let block_size = 1usize << ((limbs - 1) ^ (limbs + limbs / 9)).ilog2();
-        let limbs = limbs.next_multiple_of(block_size);
         let modulus_bytes = modulus_bytes
             .into_iter()
             .chain(vec![0u8; limbs])
@@ -717,14 +719,14 @@ pub fn moduli_init(input: TokenStream) -> TokenStream {
         let modulus_bytes = string_to_bytes(&modulus);
         let mut limbs = modulus_bytes.len();
 
-        if limbs < 32 {
+        if limbs <= 32 {
             limbs = 32;
-            proc_macro::Diagnostic::new(proc_macro::Level::Warning, "`limbs` has been set to 32 because it was too small; this is going to be changed once we support more flexible reads").emit();
+        } else if limbs <= 48 {
+            limbs = 48;
+        } else {
+            panic!("limbs must be at most 48");
         }
 
-        // The largest power of two so that at most 10% of all space is wasted
-        let block_size = 1usize << ((limbs - 1) ^ (limbs + limbs / 9)).ilog2();
-        let limbs = limbs.next_multiple_of(block_size);
         let modulus_bytes = modulus_bytes
             .into_iter()
             .chain(vec![0u8; limbs])