Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data to new nodes #10

Open
afomi opened this issue Jun 3, 2018 · 6 comments
Open

Add data to new nodes #10

afomi opened this issue Jun 3, 2018 · 6 comments
Labels
enhancement New feature or request icebox question Further information is requested

Comments

@afomi
Copy link
Member

afomi commented Jun 3, 2018

Story

As a User
I want to add an arbitrary number of key/values to any object
So I can describe nodes meaningfully

Acceptance Criteria

Given a node exists within map
When I click on a node
And I click Add Key/Value
And input new text for both Key and Value
And click Save
Then I see the new Key/Value is persisted.

@afomi afomi changed the title Add data to new cubes Add data to new nodes Jun 19, 2018
@afomi
Copy link
Member Author

afomi commented Jun 19, 2018

@theo-armour - What'd you have in mind here?

R5 supports quite a few fields. Were you thinking an arbitrary number of custom fields?

@theo-armour
Copy link
Member

@afomi

Were you thinking an arbitrary number of custom fields?

Yup. Let the JSON data file have anything JSON can have. Let the viewer app do their best to read the data. Whatever the viewer cannot read or manipulate should be left untouched.

@afomi
Copy link
Member Author

afomi commented Jun 19, 2018

@theo-armour - okay, this makes sense.

What I think about is the user interface for this. Each node or object, supports a standard set of fields, plus a number of arbitrary fields. From a data standpoint, an arbitrary number of fields can be a little tricky, but doable.

I've also been looking into other 3d file formats. .stl seems to be an open or "neutral" format, good for lower resolutions, whereas .dae files are more detailed.

Seems like there may be an opportunity for a truly open format that is convertible to other formats (with respect to limitations in various formats) - something to consider later on.


With the above said, do you have an immediate need for this? Or is this a longer-term consideration?

@afomi afomi added enhancement New feature or request question Further information is requested icebox labels Jun 19, 2018
@theo-armour
Copy link
Member

@afomi

Generally I avoid 3D file formats and try to build everything at runtime using code.

But we are certain to have a number of conversations on this topic.

So for now let's say formats are a longer term consideration

@afomi
Copy link
Member Author

afomi commented Jun 20, 2018

@theo-armour

I avoid 3D file formats and try to build everything at runtime using code.

I think this still applies to file formats, no? The runtime building of objects is just based on code not formalized as an abstract format, but likely hardcoded in the native environment's (.js / Three.js)

Definitely to discuss more.

I understand your desire to not bother with formats yet, but as we proceed, we will be be modeling and persisting data - it will be in a format, even if implicitly.

@afomi
Copy link
Member Author

afomi commented Feb 21, 2019

The feature #62 feels related to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request icebox question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants