fix(core): NanoTDF KID size enforcement #1520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced ECPublicKeyFetcher interface and its implementations to handle EC public key fetching. Updated SDK and nanotdf test cases to utilize the new interface, ensuring better abstraction and testability. Added validation for KID length and tag size in encryption methods.
pflynn-virtru
changed the title
Renamed `RealECPublicKeyFetcher` to `EcPublicKeyFetcher` for consistency. Introduced a constant for the maximum KID length and added a check for KID length in the `createNanoTDF` function.
This comment has been minimized.
This comment has been minimized.
jentfoo
previously approved these changes
Sep 5, 2024
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
pflynn-virtru
force-pushed
the
feature/kid-size-check
branch
from
7a021f6 to
e18c602
Compare
Adjusted the error message in nanotdf_test.go to specify valid tag sizes from 12 to 16 instead of 12 or 16, ensuring consistency with encryption standards.
strantalis
requested changes
Sep 6, 2024
There was a problem hiding this comment.
@pflynn-virtru I think there are unexpected changes in this pr?
auto-merge was automatically disabled
October 30, 2024 19:35
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced ECPublicKeyFetcher interface and its implementations to handle EC public key fetching. Updated SDK and nanotdf test cases to utilize the new interface, ensuring better abstraction and testability. Added validation for KID length and tag size in encryption methods.
Relates to #1506
resolves #1523