Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariadb templates Probe Warning #275

Closed
strangiato opened this issue May 3, 2021 · 6 comments
Closed

Mariadb templates Probe Warning #275

strangiato opened this issue May 3, 2021 · 6 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@strangiato
Copy link

The following Maria DB Templates have an incorrectly configured liveness/readiness probe:

  • ./official/mariadb/templates/mariadb-ephemeral.json
  • ./official/mariadb/templates/mariadb-persistent.json

When the probes are executed the following warning is logged in the pod:

2021-05-03 20:19:23 29 [Warning] Access denied for user 'userHFP'@'localhost' (using password: YES)
2021-05-03 20:19:27 30 [Warning] Access denied for user 'userHFP'@'localhost' (using password: YES)
2021-05-03 20:19:33 31 [Warning] Access denied for user 'userHFP'@'localhost' (using password: YES)

The probe is missing a ; before the mysqladmin command:

"command": [
	"/bin/sh",
	"-i",
	"-c",
	"MYSQL_PWD=\"$MYSQL_PASSWORD\"; mysqladmin -u $MYSQL_USER ping"
]
@gabemontero
Copy link
Contributor

Thanks for the info @strangiato

They way to fix it per our process is to change the files in https://github.com/sclorg/mariadb-container, working with the maintainers of the SCL mariadb code, and then this repository's background import job will pull those changes in.

Are you willing to open the issue at https://github.com/sclorg/mariadb-container or do you need me to be a proxy for this?

@strangiato
Copy link
Author

@gabemontero I can open up an issue over there. Thanks for he heads up on the correct location to get the fix.

I got started on the PR before I saw this so feel free to close out the PR.

@gabemontero
Copy link
Contributor

@gabemontero I can open up an issue over there. Thanks for he heads up on the correct location to get the fix.

I got started on the PR before I saw this so feel free to close out the PR.

that is what I figured @strangiato no worries

feel free to create a PR in https://github.com/sclorg/mariadb-container as well if you like

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2021
@coreydaley
Copy link
Member

/close
closed in favor of sclorg/mariadb-container#148

@openshift-ci openshift-ci bot closed this as completed Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@coreydaley: Closing this issue.

In response to this:

/close
closed in favor of sclorg/mariadb-container#148

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants