[PRE REVIEW]: Stingray 2: A fast and modern Python library for spectral timing #7345
Comments
editorialbot
added
pre-review
Track: 1 (AASS)
|
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type: For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type: |
|
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for 🔴 Failed to discover a |
|
License info: ✅ License found: |
|
|
|
Hi @matteobachetti, and thanks for your submission. I noticed that this submission is for Stingray v2 and Stingray v1 was previously published as a joint publication with AAS Journals. Is this submission also a joint submission with AAS Journals? Also, for the sake of whichever editor and reviewers handle this, are there specific parts of the package that are new and warrant review, or has enough changed that it's worth treating this as a fresh review anyway? I think the error in the paper is that John Swinbank has affiliation number 4 but no such affiliation is given. (The list skips from 3 to 5.) Note also that we require a statement of need, and that the paper is currently a bit longer than our stated maximum of 1000 words (though not by much). If you could squeeze it down, that'll be great. Our editors are all operating at capacity so I'm going to waitlist this submission but hopefully one will be available by the time you've addressed these initial points. |
warrickball
added
the
waitlisted
|
@warrickball thanks! First of all, let me apologize for not specifying that the paper already went through pyOpenSci review here: pyOpenSci/software-submission#201 (at pyOpenSci the editors told us not to forget this, but of course I did). There is no publication with AAS planned for now, this paper was really meant to give an update on the work we've been doing on the code since 2019, in connection with the pyOpenSci review. |
|
@matteobachetti – it would be useful to have an explicit diff here that clearly demonstrates the code changes between v1 and v2 of this library. @warrickball – assuming the scale/scope of the changes between v1 and v2 meet out 'substantial scholarly effort' criterion, we can proceed here without additional review (see https://joss.readthedocs.io/en/latest/editing.html#ropensci-reviewed-or-pyopensci-reviewed-and-accepted-submissions) |
|
@arfon, the first paper was in 2019, so basically everything you see in this changelog from 2020 on (from v.0.2 on!) was not in the first paper: |
|
In any case, thanks for the feedback! If you agree that the changes in the code are sufficient to justify a new paper, I can start working on the issues raised above from Tuesday on (upcoming proposal deadline! 😅) |
|
@editorialbot commands |
|
Hello @matteobachetti, here are the things you can ask me to do: |
|
@editorialbot check repository |
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: ✅ License found: |
|
@editorialbot check repository |
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: ✅ License found: |
|
@editorialbot check repository |
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: ✅ License found: |
|
@editorialbot check repository |
|
@editorialbot generate pdf |
|
License info: ✅ License found: |
|
@warrickball I still have a few words to cut (and if you ask how many, it's 42, Douglas Adams would be proud). I don't understand what key it is missing in line 2 column 1 🤔 |
|
Thanks for cutting it down! I'm willing to let 1042 words through and will see if I can reproduce the PDF generation error. |
|
It looks to me like this commit nudged the indentation of the |
|
Ouch. Done! |
|
@editorialbot generate pdf |
|
@editorialbot generate pdf |
|
Five most similar historical JOSS papers: Astronomical échelle spectroscopy data analysis with X-PSI: A Python package for neutron star X-ray pulse simulation and inference DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data The Pulsar Signal Simulator: A Python package for simulating radio signal data from pulsars SNEWPY: A Data Pipeline from Supernova Simulations to Neutrino Signals |
@arfon — This isn't necessarily super accurate but I couldn't get |
|
@matteobachetti — I intend to take a closer look at this soon but at a quick glance I noticed a few references aren't rendering. Specifically, note all the lingering square brackets in this sentence:
I also don't see the JOSS reference to the original Stingray publication (Huppenkothen et al. 2019b) actually turn up in the text. The associated ApJ reference (Huppenkothen et al. 2019a) is in the summary. Another few quick fixes while we're at it:
Don't worry too much about the typographic stuff. I can open a pull request to fix any minor things (like the last point) but it'll be more difficult for me to guess missing data, like exactly what you meant to cite in that sentence about methods that I quoted above. |
|
@warrickball sorry, I had gotten the syntax for citations wrong in various creative ways 😅 . Now all should appear correctly |
|
@editorialbot generate pdf |
|
Five most similar historical JOSS papers: Astronomical échelle spectroscopy data analysis with DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data SkyPy: A package for modelling the Universe The Python Sky Model 3 software SNEWPY: A Data Pipeline from Supernova Simulations to Neutrino Signals |
|
@editorialbot generate pdf |
|
Five most similar historical JOSS papers: Astronomical échelle spectroscopy data analysis with DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data SkyPy: A package for modelling the Universe SNEWPY: A Data Pipeline from Supernova Simulations to Neutrino Signals The Python Sky Model 3 software |
|
@editorialbot assign me as editor |
|
Assigned! @warrickball is now the editor |
|
@editorialbot add me as reviewer |
|
@warrickball added to the reviewers list! |
|
@editorialbot start review |
|
OK, I've started the review over in #7389. |
warrickball
added
pyOpenSci
Submitting author: @matteobachetti (Matteo Bachetti)
Repository: https://github.com/stingraysoftware/stingray
Branch with paper.md (empty if default branch): update_joss_paper
Version: 2.1
Editor: @warrickball
Reviewers: @warrickball
Managing EiC: Warrick Ball
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @matteobachetti. Currently, there isn't a JOSS editor assigned to your paper.
@matteobachetti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: