Sanitise HTML in enterprise and product descriptions

[mkllnk]

ℹ️ Please use project Discover Regenerative (Macdoch pt 2): #3A. Tech - OFN & OFN/DFC Endpoints to track work on this issue.

Description

When using a description on another website like the Discover Regenerative portal, any contained HTML tags should be safe.

Currently, the OFN UX allows only certain HTML tags to be inserted into a description. We do not check the content before storing it in the database. Instead, we sanitise the descriptions when displaying them withing the OFN app. Our APIs are not sanitising though, pushing the responsibility to all consumers of the APIs.

The knowledge of allowed HTML tags sits within OFN though and we could sanitise the HTML before storing it in the database. That would make further sanitising in the many other parts of the app redundant. It would also avoid consumers of APIs accidentally embedding unsafe HTML. It would be less work for everyone.

• Sanitise HTML in long description of enterprise [read-only] #12470
• Sanitise HTML in long description of enterprise group [read-only] #12506
• Sanitise HTML in product description [read-only] #12518
• Sanitize HTML in custom tab content [read only] #12542

Acceptance Criteria & Tests

1. All allowed HTML tags and attributes still work.
2. All other tags and attributes, including dangerous tags like <script>, are filtered out before they are exposed on the DFC API.

Related issues:

• Producer profile: long description and practices sib-discovery-components#7
• Allow product description to show images in the shopfront #8901
• Store images used in product descriptions #10376

[kirstenalarsen]

@mkllnk please add clockify code to issue and associated pull requests

[rioug]

@kirstenalarsen I can't see the clockfy code in this issue : Discover Regenerative (Macdoch pt 2): 3. Open Source Tech Evolution
I used Discover Regenerative (Macdoch pt 2): #3C. Tech - DR Site & Integration to log my code review for now, let me know if I need to update it.

[kirstenalarsen]

Good pick up @rioug . I updated the project codes to give more specificity. Have just adjusted above - could you please switch your hours to #3A

[rioug]

Done ! I also updated the description on the related PR.

[sigmundpetersen]

Hey @mkllnk , anything left on this one?

Also, #12459 connected to this

[mkllnk]

Yes, we implemented a reversible logic first and now need to do it properly. There have been no complaints about missing formatting as far as I know.