Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iOS dark icon with gradient background #6210

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 14, 2025

Hi everyone!

On iOS, many apps with dark icons don't have a flat black background, but a gradient.
This is not mandatory, but we will now better follow general rules.

Screenshot 2025-01-14 at 22 19 28

@github-actions github-actions bot added the 🍎 iOS iOS specific issues or PRs label Jan 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.22%. Comparing base (4d9c7fc) to head (ae18a67).
Report is 660 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6210      +/-   ##
==========================================
- Coverage     9.54%   6.22%   -3.33%     
==========================================
  Files          325     456     +131     
  Lines        16411   26591   +10180     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   24935   +10091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit c900822 into openfoodfacts:develop Jan 15, 2025
6 checks passed
@g123k g123k deleted the ios_icon_dark branch January 15, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants