Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editable brands #6203

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: Editable brands #6203

merged 3 commits into from
Jan 15, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 14, 2025

Hi everyone!

Now that brands are in a reorderable list, it's difficult to edit one.
With this PR, by clicking on one, you can directly change it.

Video: https://github.com/user-attachments/assets/96a4b626-e00f-48f1-afea-a8b7993d419c

IMG_1854

@github-actions github-actions bot added 🥫 Product page 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 121 lines in your changes missing coverage. Please review.

Project coverage is 6.20%. Comparing base (4d9c7fc) to head (d3fd680).
Report is 657 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% 110 Missing ⚠️
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% 7 Missing ⚠️
...ckages/smooth_app/lib/pages/text_field_helper.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6203      +/-   ##
==========================================
- Coverage     9.54%   6.20%   -3.35%     
==========================================
  Files          325     456     +131     
  Lines        16411   26699   +10288     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   25043   +10199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit ed9ee6b into openfoodfacts:develop Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page
Development

Successfully merging this pull request may close these issues.

3 participants