Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Less annoying floating spam #6190

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 12, 2025

Hi everyone!

Styles

The Floating message now have 3 styles: success / warning / error.
For the error one, the phone will also vibrate.

Loading variant

A loading variant shows the cloud animation.

IMG_1818

Dismissable popup

By clicking on the message, it will now disappear! 🎉

Background tasks

Popups for background product edits (basic details, pictures, labels, origins…) are all removed, because we have this banner on the Edit page (slightly updated):
Untitled

External page (= opens links on the browser)

If the browser can't be opened, there's now an error.
This screen also supports full URL (with http://)

IMG_1817

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 1.01010% with 98 lines in your changes missing coverage. Please review.

Project coverage is 6.27%. Comparing base (4d9c7fc) to head (a633fc4).
Report is 649 commits behind head on develop.

Files with missing lines Patch % Lines
...mooth_app/lib/widgets/smooth_floating_message.dart 0.00% 33 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_banner.dart 0.00% 30 Missing ⚠️
...mooth_app/lib/pages/product/edit_product_page.dart 5.26% 18 Missing ⚠️
.../smooth_app/lib/pages/navigator/external_page.dart 0.00% 16 Missing ⚠️
...ges/smooth_app/lib/background/background_task.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6190      +/-   ##
==========================================
- Coverage     9.54%   6.27%   -3.28%     
==========================================
  Files          325     456     +131     
  Lines        16411   26346    +9935     
==========================================
+ Hits          1567    1653      +86     
- Misses       14844   24693    +9849     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added 🥫 Product page ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🔁 Background tasks labels Jan 13, 2025
@teolemon teolemon merged commit 23288df into openfoodfacts:develop Jan 13, 2025
7 checks passed
@g123k g123k deleted the floating_spam branch January 13, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔁 Background tasks ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page router
Development

Successfully merging this pull request may close these issues.

3 participants