-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add price with the "Edit UI" #6171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6171 +/- ##
==========================================
- Coverage 9.54% 6.33% -3.22%
==========================================
Files 325 451 +126
Lines 16411 25956 +9545
==========================================
+ Hits 1567 1644 +77
- Misses 14844 24312 +9468 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
Not a big fan of the tap dancing around the floating action button, but generally speaking it looks good.
Thanks for your feedback. |
I guess there could be 2 price tags in the same pictures, couldn't it? |
We could have a counter badge on the minimized FAB. For now, merging. |
Honestly, I find that counterintuitive, but why not 😅 |
A pure UI PR:
cc @raphodn