Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store locator: Fav icon not being updated immediately #6158

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 8, 2025

Hi everyone!

Demo: https://github.com/user-attachments/assets/67c0e918-47eb-477b-b12a-f15b2e8ddcbc

There are also some optimizations in the code.

@g123k g123k linked an issue Jan 8, 2025 that may be closed by this pull request
@github-actions github-actions bot added the Prices label Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 6.36%. Comparing base (4d9c7fc) to head (414482b).
Report is 622 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/locations/search_location_preloaded_item.dart 0.00% 8 Missing ⚠️
...h_app/lib/pages/locations/location_query_page.dart 0.00% 5 Missing ⚠️
.../lib/pages/locations/favorite_location_helper.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6158      +/-   ##
==========================================
- Coverage     9.54%   6.36%   -3.18%     
==========================================
  Files          325     449     +124     
  Lines        16411   25700    +9289     
==========================================
+ Hits          1567    1637      +70     
- Misses       14844   24063    +9219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 90dd206 into openfoodfacts:develop Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Store locator: fav icons are not updated immediatelly
3 participants