Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reworked UI for ingredients/packaging input #6156

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 8, 2025

Hi everyone!

This PR changes the UI for ingredients/packaging input

🎥 Demo 1: https://github.com/user-attachments/assets/b79c9532-8a5f-4a43-adbf-c3434726fcf1
🎥 Demo 2: https://github.com/user-attachments/assets/9c048339-9cd9-43cb-970f-529729391514

Empty view

IMG_1722

Upload indicator

IMG_1718

Owner field + obsolete indicators for the photo

IMG_4C66984C054E-1

Owner field for the ingredients

Image

New placeholder for missing photos (Goodbye blueish thing)

IMG_1721

3 new icons

Screenshot 2025-01-08 at 08 19 10

@github-actions github-actions bot added 🥫 Product page 📖 Knowledge panels 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… ✏️ Editing - Basic info input 🖼️ Photos - Photo manager OCR page 📖 Knowledge panels - Map widget autocomplete labels Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.44330% with 478 lines in your changes missing coverage. Please review.

Project coverage is 6.33%. Comparing base (4d9c7fc) to head (16ad81a).
Report is 622 commits behind head on develop.

Files with missing lines Patch % Lines
...app/lib/pages/product/edit_ocr/edit_ocr_image.dart 0.00% 190 Missing ⚠️
..._app/lib/pages/product/edit_ocr/edit_ocr_page.dart 0.00% 72 Missing ⚠️
...lib/pages/product/edit_ocr/edit_ocr_textfield.dart 1.88% 52 Missing ⚠️
...mooth_app/lib/generic_lib/widgets/smooth_card.dart 0.00% 47 Missing ⚠️
...app/lib/generic_lib/widgets/picture_not_found.dart 9.52% 19 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 12 Missing ⚠️
...pages/product/edit_ocr/ocr_ingredients_helper.dart 0.00% 12 Missing ⚠️
...b/pages/product/edit_ocr/ocr_packaging_helper.dart 0.00% 11 Missing ⚠️
...th_app/lib/pages/product/product_image_viewer.dart 0.00% 11 Missing ⚠️
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% 11 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6156      +/-   ##
==========================================
- Coverage     9.54%   6.33%   -3.22%     
==========================================
  Files          325     451     +126     
  Lines        16411   25901    +9490     
==========================================
+ Hits          1567    1641      +74     
- Misses       14844   24260    +9416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k linked an issue Jan 8, 2025 that may be closed by this pull request
@teolemon
Copy link
Member

teolemon commented Jan 8, 2025

@g123k Really great work 👍
why hasn't the second product any language tabs or indication ?

@teolemon teolemon merged commit 5ddb512 into openfoodfacts:develop Jan 8, 2025
7 checks passed
@g123k
Copy link
Collaborator Author

g123k commented Jan 8, 2025

@g123k Really great work 👍 why hasn't the second product any language tabs or indication ?

Good point, that's a bug
Edit: actually the current app considers this product as monolingual, so that's OK

@g123k g123k deleted the ocr_improvements_ok branch January 8, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete ✏️ Editing - Basic info input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 📖 Knowledge panels - Map widget 📖 Knowledge panels 🌐 l10n OCR page 🖼️ Photos - Photo manager 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
3 participants