-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated major versions for frontend-platform & paragon #947
feat: updated major versions for frontend-platform & paragon #947
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
=======================================
Coverage 67.76% 67.76%
=======================================
Files 128 128
Lines 3229 3229
Branches 913 913
=======================================
Hits 2188 2188
Misses 996 996
Partials 45 45 ☔ View full report in Codecov by Sentry. |
…-publisher into bilalqamar95/frontend-platform-upgrade
0ede69b
to
57f16f9
Compare
…-publisher into bilalqamar95/frontend-platform-upgrade
57f16f9
to
b74a091
Compare
…-publisher into bilalqamar95/frontend-platform-upgrade
@Ali-D-Akbar can you please merge it as well, I don't have the permission for it |
Hey @Ali-D-Akbar, are there any blockers on merging this? |
@BilalQamar95 Hi there, sorry about the delay. This PR requires some good local testing. We'll hopefully get this done this week and let you know if everything is okay and merge it. Thanks. |
@Ali-D-Akbar Any updates on when this is going to get merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local, Changes LGTM 👍🏻 , Good to go
@AfaqShuaib09 can you please merge it? |
"@edx/openedx-atlas": "^0.6.0", | ||
"@edx/paragon": "^20.44.0", | ||
"@openedx/paragon": "^21.11.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we moving some packages from the edx namespace to openedx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can view axim-engineering#23 for details. I have also updated the description
Description
@edx/paragon
&@edx/frontend-build
to use openedx namespace. Updated imports & respective packages (Part of NPM Ownership axim-engineering#23)frontend-build
to v14 &frontend-platform
to v8