Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency tinymce to v5.10.9 [security] #930

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 15, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tinymce (source) 5.10.8 -> 5.10.9 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-48219

Impact

A mutation cross-site scripting (mXSS) vulnerability was discovered in TinyMCE’s core undo/redo functionality and other APIs and plugins. Text nodes within specific parents are not escaped upon serialization according to the HTML standard. If such text nodes contain a special character reserved as an internal marker, they can be combined with other HTML patterns to form malicious snippets. These snippets pass the initial sanitisation layer when the content is parsed into the editor body, but can trigger XSS when the special internal marker is removed from the content and re-parsed. Such mutations occur when serialised HTML content is processed before being stored in the undo stack, or when the following APIs and plugins are used:

Patches

This vulnerability has been patched in TinyMCE 6.7.3 by:

  • ensuring that any unescaped text nodes which contain the special internal marker are emptied before removing the marker from the rest of the HTML, and
  • removing the special internal marker from content strings passed to Editor.setContent, Editor.insertContent, and Editor.resetContent APIs to prevent them from being loaded into the editor as user-provided content.

Fix

To avoid this vulnerability:

  • Upgrade to TinyMCE 6.7.3 or higher for TinyMCE 6.x.
  • Upgrade to TinyMCE 5.10.9 or higher for TinyMCE 5.x.

Acknowledgements

Tiny Technologies would like to thank Masato Kinugawa of Cure53 for discovering this vulnerability.

References

For more information

Email us at [email protected]
Open an issue in the TinyMCE repo


Release Notes

tinymce/tinymce (tinymce)

v5.10.9

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb8d227) 67.17% compared to head (2d61f2e) 67.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files         128      128           
  Lines        3211     3211           
  Branches      927      927           
=======================================
  Hits         2157     2157           
  Misses       1005     1005           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot merged commit b9c5cbc into master Nov 15, 2023
5 checks passed
@renovate renovate bot deleted the renovate/npm-tinymce-vulnerability branch November 15, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants