fix: request error for empty user list responses

[DmytroAlipov]

Description:

"An unexpected error occurred" if you try to get all responses when the users' list is empty:

1. Open ORA Grading:

2. In Search username fill in not existing student username:

3. Click on View all responses:

I suggest not sending a request if the users are not on the list.

[openedx-webhooks]

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[openedx-webhooks]

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (59a7d07) to head (20cd6bc).

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1078      1079    +1     
  Branches       159       160    +1     
=========================================
+ Hits          1078      1079    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

Hi @openedx/content-aurora! This is ready for review.

[arbrandes]

While this solves the error message, it doesn't fix the problem completely: there's still no user feedback when the button is pressed with an empty list of results.

I believe a better fix would be to show a message in the ShowReview modal to the effect that no responses were selected. Is this something you can take on?

[arbrandes]

Or, for a possibly an easier fix, to grey out the View all responses button when none are showing.

[DmytroAlipov]

Hi, @arbrandes!
I think an inactive (gray) button would be a good option and, at first glance, not a difficult task. I'll try to implement this.

[DmytroAlipov]

@arbrandes I made the button inactive. Now you can't send a request if the list is empty.

[arbrandes]

Brilliant! Not to be too picky, but do you mind adding a unit test for when the button should be disabled (and when it shouldn't)?

[DmytroAlipov]

@arbrandes Now this is implemented as a snapshot (button enabled). If I make a test also based on a snapshot with only the button disabled, will such a test be ok?

[DmytroAlipov]

@arbrandes I added a test😉

[arbrandes]

Alright, looks good, thank you for bearing with me!

[openedx-webhooks]

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.