Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show an alert when relative dates are due #1300

Closed

Conversation

DanielVZ96
Copy link

Description

There used to be an alert on the unit page that informed users about the missed deadline and allowed them to reset the due dates. When we implemented enforcing these dates, we had to hide this banner, as there were lots of code dependencies tied to this. We still want to warn students that the unit can't be modified in an alert.

Note: Implementation depends on this PR

Testing Steps

  1. Checkout this branch in edx-platform
  2. Add a deadline to any assigment or exam
  3. Navigate to it as a non-staff learner
  4. Assert the banner appears.

Screenshots

image

@openedx-webhooks
Copy link

Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@21698b4). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1300   +/-   ##
===========================================================
  Coverage                            ?   86.96%           
===========================================================
  Files                               ?      253           
  Lines                               ?     4373           
  Branches                            ?     1110           
===========================================================
  Hits                                ?     3803           
  Misses                              ?      551           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVZ96 DanielVZ96 closed this Mar 1, 2024
@openedx-webhooks
Copy link

@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants