feat: refactor date visibility #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 88.37% 88.38%
=======================================
Files 291 291
Lines 4948 4949 +1
Branches 1251 1251
=======================================
+ Hits 4373 4374 +1
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
alangsto
commented
Feb 22, 2024
| }, | ||
| courseMetadata: Factory.build('courseMetadata', { | ||
| start: '2014-02-03T05:00:00Z', | ||
| end: '2014-02-05T05:00:00Z', |
There was a problem hiding this comment.
I'm just testing course end date here, because if the enrollment start and end are null, they will both default to the respective course start or course end date. I can add additional tests for each case if there is a need for it.
MichaelRoytman
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date related code for the Chat component should be moved to the Chat component itself.