-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: broken readme fixed #1264
Conversation
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 291 291
Lines 4945 4945
Branches 1247 1247
=======================================
Hits 4370 4370
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@CodeWithEmad Thank you for this contribution! It looks like the changes are ready for review, but please let me know if that's not the case. |
Yeah, it's not much, but will fix the broken README. |
@e0d This is a trivial fix, can we consider it eligible for CC review and merge? EDIT: The first meeting of the Maintenance WG answered this question -- we can let CCs take on Reviews and Merges that they can manage. |
Hey @BbrSofiane, as a core contributor for frontend-app-learning, would you have time to give this a quick look and merge it? It's a trivial change so shouldn't take more than 5 mins to review. |
@BbrSofiane A friendly ping about my question above. If you don't have bandwidth for reviewing PRs from this repo right now, no problem! Please just let me know so I can start looking for other reviewers. |
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This will fix a typo and the broken README page.
Close #1266