Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: broken readme fixed #1264

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Dec 31, 2023

This will fix a typo and the broken README page.
Close #1266

@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (54bb72b) to head (7cd92e0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         291      291           
  Lines        4945     4945           
  Branches     1247     1247           
=======================================
  Hits         4370     4370           
  Misses        561      561           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Jan 12, 2024

@CodeWithEmad Thank you for this contribution! It looks like the changes are ready for review, but please let me know if that's not the case.

@CodeWithEmad
Copy link
Member Author

Yeah, it's not much, but will fix the broken README.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jan 18, 2024
@itsjeyd
Copy link

itsjeyd commented Feb 1, 2024

@e0d This is a trivial fix, can we consider it eligible for CC review and merge?

EDIT: The first meeting of the Maintenance WG answered this question -- we can let CCs take on Reviews and Merges that they can manage.

CC @mphilbrick211

@itsjeyd
Copy link

itsjeyd commented Feb 8, 2024

Hey @BbrSofiane, as a core contributor for frontend-app-learning, would you have time to give this a quick look and merge it? It's a trivial change so shouldn't take more than 5 mins to review.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

@BbrSofiane A friendly ping about my question above.

If you don't have bandwidth for reviewing PRs from this repo right now, no problem! Please just let me know so I can start looking for other reviewers.

@jristau1984 jristau1984 merged commit 4797425 into openedx:master Mar 3, 2024
7 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the docs/typo branch March 3, 2024 12:56
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

README file broken
4 participants