Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate assignment types for Quince #920

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Mar 26, 2024

This is a backport from the master branch.

Description

  1. Possible save just space forAssignment type name
  2. Possible save Number of droppable field with values more than the Total number value which leads to displaying errors all the time
  3. Possible save Weight of total grade field with empty values:
    44

Implemented so that when an error occurs, the modal window containing the Save changes button is not displayed:

12 11

Fixed display of errors for the Number of droppable field:

14 15

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 26, 2024

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/quince.master@9192287). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #920   +/-   ##
=============================================================
  Coverage                              ?   87.00%           
=============================================================
  Files                                 ?      378           
  Lines                                 ?     5711           
  Branches                              ?     1265           
=============================================================
  Hits                                  ?     4969           
  Misses                                ?      722           
  Partials                              ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 requested a review from a team March 26, 2024 18:14
@mphilbrick211
Copy link

Hi @openedx/2u-tnl - this is ready for review. Thanks!

@DmytroAlipov DmytroAlipov force-pushed the fix-valdate-assignment-types-quince branch from 4efb9be to 45f6bfe Compare March 26, 2024 18:16
@DmytroAlipov
Copy link
Contributor Author

Hi @mphilbrick211 exactly

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Mar 26, 2024
Copy link
Member

@jesperhodge jesperhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I left a comment in the other ticket, if you do add any test you may want to copy it over to here, but that's not very important.

@mphilbrick211
Copy link

Hi @DmytroAlipov and @jesperhodge - just checking to see if this is all set?

@ihor-romaniuk ihor-romaniuk added the backport PR backports a change from main to a named release. label Jun 3, 2024
@mphilbrick211
Copy link

Hi @jesperhodge! Are you able to merge this for us?

@KristinAoki
Copy link
Member

There are some issues that still need to be resolved in the original PR before the backport can be merged.

@mphilbrick211
Copy link

There are some issues that still need to be resolved in the original PR before the backport can be merged.

The original has been closed - @KristinAoki do we still need this?

@KristinAoki
Copy link
Member

@mphilbrick211 the orginal issue has been open in a new PR, #1059. The new PR is a draft so I think this PR can be closed and a new one open when #1059 is ready for review.

@DmytroAlipov DmytroAlipov deleted the fix-valdate-assignment-types-quince branch September 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants