-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validate assignment types for Quince #920
Fix validate assignment types for Quince #920
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #920 +/- ##
=============================================================
Coverage ? 87.00%
=============================================================
Files ? 378
Lines ? 5711
Branches ? 1265
=============================================================
Hits ? 4969
Misses ? 722
Partials ? 20 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-tnl - this is ready for review. Thanks! |
4efb9be
to
45f6bfe
Compare
Hi @mphilbrick211 exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I left a comment in the other ticket, if you do add any test you may want to copy it over to here, but that's not very important.
Hi @DmytroAlipov and @jesperhodge - just checking to see if this is all set? |
Hi @jesperhodge! Are you able to merge this for us? |
There are some issues that still need to be resolved in the original PR before the backport can be merged. |
The original has been closed - @KristinAoki do we still need this? |
@mphilbrick211 the orginal issue has been open in a new PR, #1059. The new PR is a draft so I think this PR can be closed and a new one open when #1059 is ready for review. |
This is a backport from the master branch.
Description
space
forAssignment type name
Number of droppable
field with values more than theTotal number
value which leads to displaying errors all the timeWeight of total grade
field with empty values:Implemented so that when an error occurs, the modal window containing the
Save changes
button is not displayed:Fixed display of errors for the Number of droppable field: