Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disabled MITx from program nudge emails #36071

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Jan 2, 2025

Description

This PR adds the ability to exclude specific organisations from the program nudge emails. (e.g. next course)

Supporting information

Exempt an organisation's courses from the send_program_course_nudge emails that are designed to go out to a learner after they have earned a passing grade in a course for 2 reasons:

  1. Timing - these are being sent out before their course end dates have passed AND before certificate display availability dates have passed.
  2. Inaccurate recommendations - one of their program series has a set sequence, and this nudge could recommended a course that is sequentially supposed to follow one more course.

As our nudge email is designed to look at the passed_timestamp and seemingly not much else, this overlooks important pieces like: has the course actually ended, has the assignment due date passed, have certificates been made available to learners in the course yet, is the learner in the course on the verified enrollment track in the course they just completed or are they an instructor or something else, etc.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-6471 branch 4 times, most recently from 61d19de to 46aaadd Compare January 3, 2025 13:28
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-6471 branch 2 times, most recently from bae8e17 to 23e703a Compare January 9, 2025 13:02
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-6471 branch 2 times, most recently from fadd539 to a276306 Compare January 14, 2025 12:04
Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irfanuddinahmad irfanuddinahmad merged commit fd3cfac into master Jan 15, 2025
48 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-6471 branch January 15, 2025 09:46
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants