Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce monitoring noise from large third party cookies #329

Open
rgraber opened this issue Jul 27, 2023 · 0 comments
Open

Reduce monitoring noise from large third party cookies #329

rgraber opened this issue Jul 27, 2023 · 0 comments

Comments

@rgraber
Copy link
Contributor

rgraber commented Jul 27, 2023

Context
We have a few large cookies in our cookie headers that we are pretty sure we're not going to be able to get rid of or make smaller, mostly from third parties. They may be diverting attention from other large cookies we can fix or remove.

Proposal
Split the cookie size calculations into ones that factor in these third party cookies and ones that don't.

Implementation details:
Add a new COOKIE_LOGGING_IGNORE_LIST setting that takes a list of prefixes
Add a new COOKIE_HEADER_WITH_EXCLUSIONS_SIZE_LOGGING_THRESHOLD setting (needs a better name)
Split the large cookie header logging code into two parts:

  1. If the total size is over COOKIE_HEADER_SIZE_LOGGING_THRESHOLD, log everything
  2. Otherwise, check the size of the header excluding cookies matching those in COOKIE_LOGGING_IGNORE_LIST
  3. If the new size is over COOKIE_HEADER_WITH_EXCLUSIONS_SIZE_LOGGING_THRESHOLD, log everything except the cookies that were ignored
  4. Add a new custom attribute for the new size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant