Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Requesting CC Onboarding for Usama Sadiq with gh username UsamaSadiq #1358

Closed
UsamaSadiq opened this issue Jan 15, 2025 · 16 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@UsamaSadiq
Copy link
Member

Firm Name

Arbisoft

User List (case sensitive!) - Please also include in ticket title

UsamaSadiq

User Squad

No response

Core Contributor nomination thread

https://discuss.openedx.org/t/core-contributor-nomination-usama-sadiq/14562/6

Start Date

Jan 16 2025

Urgency

Medium (< 2 weeks)

Special Requests

Need maintainer access for the repos django-config-models, edx-rest-api-client and django-user-tasks as per the request in the forums thread https://discuss.openedx.org/t/seeking-maintainers-for-edx-platform-dependencies/14310

@UsamaSadiq UsamaSadiq added the github-request Request for change to access level or settings in the openedx GitHub organization. label Jan 15, 2025
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@bmtcril bmtcril self-assigned this Jan 15, 2025
@bmtcril bmtcril moved this from Backlog to In Progress in Axim Engineering Tasks Jan 15, 2025
@sarina sarina changed the title [GH Request] Requesting CC access for Usama Sadiq with gh username UsamaSadiq to repos django-config-models, edx-rest-api-client and django-user-tasks. [GH Request] Requesting CC Onboarding for Usama Sadiq with gh username UsamaSadiq Jan 15, 2025
@bmtcril
Copy link
Contributor

bmtcril commented Jan 15, 2025

CC Onboarding Checklist for Axim On-Call

  • Ensure their Salesforce (SF) contact is set up correctly. This step is usually a no-op, but it might require work if, e.g., the new CC recently changed firms and/or they only contributed code outside of the openedx org.
    • The SF contact should exist under their name and GitHub handle. Open edX Individual CLA should be checked. If any of this missing, then have them sign an individual CLA, and then confirm that it is reflected in SF. This may take a couple days.
    • Exactly one of the following scenarios should be true. If not, you will need to talk to both the new CC and a trusted point of contact from the Firm in question to make sure everybody's on the same page. If it's not obvious what to do, talk to the Axim eng team.
      • Employed CC scenario: The onboarding request specifies a Firm Name that matches the SF contact's Account Name, and Contributor Covered Under Entity CLA is checked.
      • Independent CC scenario: The onboarding request specifies "none" / "independent" for Firm Name. The SF contact's Account Name is ... Household, and Contributor Covered Under Entity CLA is unchecked.
    • The SF contact should specify an email address. You will need this for the remaining steps.
  • Invite them by email address to the Core Contributor Onboarding course (link requires login) and let them know they need to complete the steps before they’re fully considered a core contributor.
  • Confirm with them that they received the course invitation and have successfully accessed the training course.
  • Let CC know that they may be required to take the privacy and a11y courses when they become available.
  • Verify with Sarina or Axim Legal that the new Core Contributor successfully completed the required legal documents, including both the CLA and the CC Agreement. (Usually Legal will contact the CC Admins about this so you can check in with them if it’s been a little while). Keep the ticket open with status “Blocked” until this is done. Once complete, follow the remaining steps (some may be handled by the CC onboarding course now).
  • Invite the CC to the Open edX #core-contributors Slack channel.
  • Add them to the overall CC mailing list.
  • Add them to the Core Contributors list.
  • Back in their Salesforce contact record, go to their Role and add "Core Contributor".
  • Ensure they are in the openedx GitHub organization and a member of the openedx-triage
  • Send Fox a direct message on Slack with the full name and email address of the new CC. (Fox will contact the new CC explaining the bi-weekly check-ins at Listaflow.com, and provide the CC with a link to the latest sprint retro recap thread in the forums.
  • Ask a Forum Moderator to award the “Core Contributor” badge to the person’s forums profile. (forum moderation rights are listed on the Core Contributors page).

Additional, for Coding Roles Only

  • Add them to the Google group. This is very low traffic, meant primarily for announcements we want to be sure get to all developers.
  • Add the CC to the @core-contributor-committers Slack user group
  • Ask them to review the Merge Guidelines for Coding Core Contributors and join the two Slack channels mentioned at the top of the guidelines.
  • Remind them to add themselves to the relevant shared Slack channel(s) corresponding to their merge accesses (some additional context if you’re curious). Here’s a DM you can copy and use: “For the repositories you have merge access to, please join the Slack room(s) that correspond to your repositories. These rooms are where to coordinate timing on merging breaking or major changes. Keep in mind that 2U runs CI/CD off the tip of master branches, so major changes will impact their site first. It's generally OK to announce in these rooms that you are merging a pr with 24 hour or more notice (eg, I'm merging this tomorrow at 1500 UTC), and engage in discussion with anyone who expresses concern. These rooms are also a good place to ask for a 2U review on critical/breaking change PRs before you get to the merging state.”
  • Also add them to the GitHub group committers teams.
  • Grant write access to the repositories described in the vote. Do not grant it directly to the user; instead, use existing committers- teams, making new ones as you need to. See this page for details.

@bmtcril
Copy link
Contributor

bmtcril commented Jan 15, 2025

Hi @UsamaSadiq , welcome! The big checklist above are the steps we need to complete for your CC onboarding. I've invited you to the onboarding course, we can complete the rest of the steps once you've completed the course. You should be able to access if here with your arbisoft email address if you didn't get the email. You may have to complete other courses in the future as well.

You'll also need to sign an individual license agreement here: https://openedx.org/cla

Once you've finished the onboarding course I'll go through the rest of the steps to get you all set up. Let me know if you run into any issues!

@bmtcril bmtcril moved this from In Progress to Blocked in Axim Engineering Tasks Jan 15, 2025
@UsamaSadiq
Copy link
Member Author

Hi @bmtcril
Thanks for the quick update.

I've successfully signed up for onboarding course through the invitation.
As for the CLA, I'm already contributing under 2U CLA so I want to confirm if I need to sign another CLA for my individual contributions?

@bmtcril
Copy link
Contributor

bmtcril commented Jan 16, 2025

Hi @UsamaSadiq , yes you do need to sign an individual CLA as a CC. The CC relationship is with you as an individual, so this would also let you continue to contribute regardless of whether your status with 2U changed or if you moved under a different organization.

@UsamaSadiq
Copy link
Member Author

@bmtcril
Update: I've successfully filled up the CLA sign up form and signed the agreement shared with me by email. Currently, undergoing the Core Contributor Onboarding course.

@bmtcril
Copy link
Contributor

bmtcril commented Jan 17, 2025

Great! Let me know when you've finished up the CC onboarding course and we'll wrap up the last steps.

@bmtcril
Copy link
Contributor

bmtcril commented Jan 17, 2025

Actually we're not seeing any DocuSign agreement from you yet, did you send send the email from your personal address and use the same name there are you have here? The details are in the checklist here: https://apps.training.openedx.io/learning/course/course-v1:OpenedX+NewCC+2024/block-v1:OpenedX+NewCC+2024+type@sequential+block@9ad2f27d33d448709a1ef6edc55d2bf0/block-v1:OpenedX+NewCC+2024+type@vertical+block@75c10155fb1c4270b7d975a063b6ba61

@UsamaSadiq
Copy link
Member Author

Hi @bmtcril
I've two email addresses associated with my GitHub account ([email protected] and [email protected] ) and till now I've followed these steps:

  • Logged into the apps.training.openedx.io portal using my arbisoft email account [email protected]
  • Filled up the individual CLA form and provided my email ([email protected]) and GitHub Handle (UsamaSadiq)
  • Got an invitation to sign a digital agreement on my email address ([email protected]) which I submitted using the same account.
Image

@bmtcril
Copy link
Contributor

bmtcril commented Jan 21, 2025

I see, it looks like Eden created a new contact for you with your personal email address. @sarina do you have any guidance in how to untangle this?

@sarina
Copy link
Contributor

sarina commented Jan 21, 2025

@UsamaSadiq did you go through the CC Onboarding Course? In the course there are instructions to email the CC Program Admins from your personal email address. I do not have record that you have done this. Kindly check the course and ensure you've done this step.

@UsamaSadiq
Copy link
Member Author

UsamaSadiq commented Jan 22, 2025

@sarina I was following Brian's comments on this issue and went for signing CLA directly before starting my Onboarding course.
Yes, I've seen the provided template but I wanted to get a clear understanding since the Core Contributor Program Agreement was already sent to my email account. I've sent the email as well for the record.

@UsamaSadiq
Copy link
Member Author

UsamaSadiq commented Jan 22, 2025

@bmtcril I'm not able to login/signup using my personal email address ([email protected]) into the openedx.atlassian.net domain.
Would you be able to help me out in this so I can update my details in the core contributor wiki page and mark the course as completed.
Also, currently my core contributor course is associated with my work email account ([email protected]) [ I received initial invite on this address ] and I'd prefer it to be associated with my personal email account ('[email protected]) instead if possible. This'll help me in keeping all the OpenedX work under the personal email address umbrella.

@sarina
Copy link
Contributor

sarina commented Jan 22, 2025

@UsamaSadiq the individual CLA was sent to your personal email address, not the Core Contributor Program Agreement. I've just received your email to start the CC Agreement paperwork. Thanks.

@sarina
Copy link
Contributor

sarina commented Jan 22, 2025

@bmtcril Usama's CC Program Agreement has been executed.

@bmtcril
Copy link
Contributor

bmtcril commented Jan 22, 2025

Ok Usama, you should be all set. Your permissions have been updated and you've been added to all of the mailing lists, groups, and Slack channels. As a reminder:

  • Please review the Merge Guidelines for Coding Core Contributors and join the two Slack channels mentioned at the top of the guidelines.
  • For the repositories you have merge access to, please join the Slack room(s) that correspond to your repositories. These rooms are where to coordinate timing on merging breaking or major changes. Keep in mind that 2U runs CI/CD off the tip of master branches, so major changes will impact their site first. It's generally OK to announce in these rooms that you are merging a pr with 24 hour or more notice (eg, I'm merging this tomorrow at 1500 UTC), and engage in discussion with anyone who expresses concern. These rooms are also a good place to ask for a 2U review on critical/breaking change PRs before you get to the merging state.

Let me know if you run into any issues!

@bmtcril bmtcril closed this as completed Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Blocked to Done in Axim Engineering Tasks Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

3 participants