From 0eebb7b42ff21728adf54986d02e4f4eb0a34ab8 Mon Sep 17 00:00:00 2001 From: Josemi Date: Fri, 10 Jan 2025 13:31:59 +0100 Subject: [PATCH] wc: Remove unused code in jupyter notebook tool #TASK-7216 #TASK-7100 --- .../commons/analysis/jupyter-notebook.js | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/webcomponents/commons/analysis/jupyter-notebook.js b/src/webcomponents/commons/analysis/jupyter-notebook.js index 35201de8d..e34b2eba0 100644 --- a/src/webcomponents/commons/analysis/jupyter-notebook.js +++ b/src/webcomponents/commons/analysis/jupyter-notebook.js @@ -43,7 +43,7 @@ export default class JupyterNotebook extends LitElement { } #init() { - this.enter = false; + this._enter = false; this._config = this.getDefaultConfig(); } @@ -54,24 +54,13 @@ export default class JupyterNotebook extends LitElement { ...this.config }; } + super.update(changedProperties); } onEnterClick() { - this.enter = true; + this._enter = true; this.requestUpdate(); - - // Execute function provided in the configuration - /* if (this.analysisClass.execute) { - this.analysisClass.execute(this.opencgaSession, e.detail.data, e.detail.params); - } else { - console.error(`No execute() function provided for analysis: ${this._config.id}`) - }*/ - - // // TODO NOTE onAnalysisRun at the moment just forwards the `analysisRun` event fired in opencga-analysis-tool-form - // this.dispatchEvent(new CustomEvent("execute", { - // detail: e.detail - // })); } renderWelcomeView() { @@ -126,7 +115,7 @@ export default class JupyterNotebook extends LitElement { - ${this.enter ? this.renderJupyterFrame() : this.renderWelcomeView()} + ${this._enter ? this.renderJupyterFrame() : this.renderWelcomeView()} `; }