Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPO2 clip value loss #765

Open
yuhsh24 opened this issue Dec 17, 2018 · 5 comments
Open

PPO2 clip value loss #765

yuhsh24 opened this issue Dec 17, 2018 · 5 comments

Comments

@yuhsh24
Copy link

yuhsh24 commented Dec 17, 2018

If Clip the value to reduce variability during Critic training, why using tf.maximum(tf.square(vpred - R), tf.square(vpredclipped - R)) instead of using tf.minimum. Please tell me the reasons.

@NoelFeiyang
Copy link

I have the same question.
Also, the clip range tf.clip(vpred-OLDVPRED, -CLIPRANGE, CLIPRANGE) is weird. Probably it should be tf.clip(vpred-OLDVPRED, -tf.abs(OLDVPRED)*CLIPRANGE, tf.abs(OLDVPRED)*CLIPRANGE)??

@rallen10
Copy link

Does anyone have further insight on either/both of the questions posed?

@brett-daley
Copy link
Contributor

Issue #445 has some discussion on this

@shtse8
Copy link

shtse8 commented Aug 27, 2020

I have the same question too. Searched for an answer but no luck. Please tell me the reason why it uses maximum instead of minimum.

@shtse8
Copy link

shtse8 commented Aug 27, 2020

Ok. I got the answer now.
Because baseline calculate pgloss1 and pgloss2 with negative sign. So that it uses maximum afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants