Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no save model option for DDPG #566

Closed
Kuppharish opened this issue Sep 6, 2018 · 2 comments
Closed

There is no save model option for DDPG #566

Kuppharish opened this issue Sep 6, 2018 · 2 comments

Comments

@Kuppharish
Copy link

I'm using the DDPG API to run my environment. It trains perfectly fine when I use the command:
python -m baselines.ddpg.main
But I can't store the progress as the API doesn't have a save option. I tried to edit the code to get the desirable results. I added tf.train.Saver.save(sess) at the end of the code and tf.train.Saver.restore after the with U.single_threaded_session() as sess: statement which throws out following error:

TypeError: restore() missing 1 required positional argument: 'save_path'

Please tell me what is going wrong here, Thanks.

@iSaran
Copy link

iSaran commented Sep 11, 2018

Take a look at #162, it is the same issue.

@brendenpetersen
Copy link

@Kuppharish Keep in mind that even if you save/restore the policy as in #162, if normalize_observations=True (the default value), then the mean/std used for normalization will not be recoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants