Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A2C some feedback #413

Open
simoninithomas opened this issue May 27, 2018 · 0 comments
Open

A2C some feedback #413

simoninithomas opened this issue May 27, 2018 · 0 comments

Comments

@simoninithomas
Copy link
Contributor

simoninithomas commented May 27, 2018

Hi!

First of all thank you very much for your awesome work, the baselines are really good, but please comment your code because some part of it are not intuitive at all.

I think it can be a good idea to have a sort of documentation for each architecture and a small tutorial to explain why your architecture is implemented like that..

By the way I wanted to know why you implement some functions instead of using Tensorflow? For instance cat_entropy. Is there a reason or it's just because you prefer implement them?

Thanks again for your work!
Have a great day!

@simoninithomas simoninithomas changed the title A2C some feedback and what are step_policy and train_policy? A2C some feedback and some questions May 27, 2018
@simoninithomas simoninithomas changed the title A2C some feedback and some questions A2C some feedback May 31, 2018
AdamGleave pushed a commit to HumanCompatibleAI/baselines that referenced this issue Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant