Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in baselines/ddpg/ddpg.py? #179

Open
MogicianWu opened this issue Oct 25, 2017 · 3 comments
Open

Bug in baselines/ddpg/ddpg.py? #179

MogicianWu opened this issue Oct 25, 2017 · 3 comments

Comments

@MogicianWu
Copy link

When I tried to run popart and return normalization, the program crashed at setup_popart() method in line 195. After looking at models.output_vars method, I found no variable in the graph has 'output' in their name. Is this a possible bug?

@watts4speed
Copy link

watts4speed commented Jan 26, 2018

I saw the same thing. There's also code that's looking for some additional sub-strings. A fix will need to account for these also. If I can get this running I'll post something for others.

    for vs in [self.critic.output_vars, self.target_critic.output_vars]:
        assert len(vs) == 2
        M, b = vs
        assert 'kernel' in M.name
        assert 'bias' in b.name
        assert M.get_shape()[-1] == 1
        assert b.get_shape()[-1] == 1

@bjmuld
Copy link

bjmuld commented Apr 3, 2018

samesies

@kirk86
Copy link

kirk86 commented Aug 1, 2018

Any progress on this? ddpg seems to have multiple problems. I found that using mpirun with np > 2 throws an error because of NaNs in the thetalocal variable inside the MpiAdam class although the var_list seems to contain variables and it's not empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants