Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package metadata diff doesn't work between revisions 0 and 1 #17107

Open
dmach opened this issue Nov 14, 2024 · 1 comment
Open

package metadata diff doesn't work between revisions 0 and 1 #17107

dmach opened this issue Nov 14, 2024 · 1 comment
Labels
Backend Things regarding the OBS backend Bug

Comments

@dmach
Copy link
Contributor

dmach commented Nov 14, 2024

/source/<project>/<package>?cmd=diff&&orev=0&rev=1&meta=1 doesn't work
The same request with meta=0 works fine.

See:
osc api -X POST 'https://api.opensuse.org/source/openSUSE:Tools/osc?cmd=diff&expand=1&orev=0&rev=1&meta=1'
osc api -X POST 'https://api.opensuse.org/source/openSUSE:Tools/osc?cmd=diff&expand=1&orev=0&rev=1&meta=0'

@eduardoj
Copy link
Member

That endpoint works as it is defined by the backend. The frontend only passes the request directly to the backend.

Code of the frontend passing it to the backend:

# POST /source/<project>/<package>?cmd=diff
def package_command_diff
# oproject_name = params[:oproject]
# opackage_name = params[:opackage]
path = request.path_info
path += build_query_from_hash(params, %i[cmd rev orev oproject opackage expand linkrev olinkrev
unified missingok meta file filelimit tarlimit
view withissues onlyissues cacheonly nodiff])
pass_to_backend(path)
end

Code of the backend endpoint:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Things regarding the OBS backend Bug
Projects
None yet
Development

No branches or pull requests

2 participants