-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all UBERONParcellations from UBERON Minimal Nervous System subset #133
Comments
This will also be an update of existing terms since the convention for the definition (and description) has change e.g., definitions don't start with the repetition of the name of the term anymore. |
@UlrikeS91 what is the status if this is reopened? |
I envisioned this issue to be used to collect all PRs related to this. @Raphael-Gazzotti closed it after we merged the first PR related to this issue, but the idea was to make multiple smaller PRs for all the UBERON parcellations and link them to this issue. And then, once we integrated all relevant terms into openMINDS, close this issue. We can organize this differently if you'd like. I'm open to suggestions 🙂 |
@UlrikeS91 generally comment: we should aim for issues that we can close within one PR. If this is not feasible (because sometimes issues are just bigger) we need to have at least a concrete list of PRs todo so that someone not overseeing the outreach of the issue can follow up what the status is. For this issue, maybe provide a checklist of TODOs and mark those who were already accomplished in an PR. You can connect the PR IDs to each checklist point when you (or someone else) started the PR for that point. Is this feasible for this issue? (I know that this covers a lot of changes) |
We did not add all relevant UBERONParcellations. Since there have been a few requests for adding more parcellations and these are very straight forward to add, I decided to pull the entire subset and create the openMINDS instances.
A short summary:
[auto-generated from 'is_a' property of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_<<ID>>)]
[auto-generated from 'relationship' property of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_<<ID>>)]
[auto-generated from properties of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_<<ID>>) ('is_a' and 'relationship')]
[definition of the [UBERON ontology term](http://purl.obolibrary.org/obo/UBERON_<<ID>>)]
instead, so that users can go there and see the original reference in its original context where it makes more sensehttp://purl.obolibrary.org/obo/UBERON_<<ID>>
)Please note that it is up for discussion which of the over 2800 terms should be added as an UBERONParcellation! I don't think we should add all from this subset, but I want those discussions to happen in the repo (or offline with a conclusion in the corresponding PR).
EDIT (17.01.2025):
The checklist represents the PRs related to this issue. When there is just a name and no link, the PR still needs to be made. When a link is added, the PR exists. Number in brackets is the number of terms included in each PR. Once ticked off, the PR is merged (and conclusion for what has been added or not is in the thread of the PR).
The terms were sorted in the same order of the checklist. This is important to know since some terms contain multiple keywords that I sorted by. For example, 'blood brain barrier' was sorted into 'blood related terms' because this was done before sorting by 'border related terms'. Over 2000 terms were sorted following a specific logic/logical grouping (details will be described in each PR), and each PR has different number of terms included. The remaining 600 terms are sorted alphabetically and each PR contains 50 terms (A01 - A12).
The text was updated successfully, but these errors were encountered: