Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] Support Prometheus v3 translation_strategy NoUTF8EscapingWithSuffixes #1480

Open
Pionerd opened this issue Dec 28, 2024 · 1 comment
Labels
chart:demo Issues related to opentelemetry-demo helm chart

Comments

@Pionerd
Copy link
Contributor

Pionerd commented Dec 28, 2024

When following https://prometheus.io/docs/guides/opentelemetry/, setting the translation_strategy to NoUTF8EscapingWithSuffixes renames the metrics ingested into Prometheus, e.g. from traces_span_metrics_duration_milliseconds_bucket to traces.span.metrics.duration_milliseconds_bucket.

I do not immediately oversee all consequences of this, one is that the Grafana dashboards break.

Is this translation_strategy something we like to implement? I can start on a PR if so. The reason is that we would like to set this strategy in an existing Prometheus instance we fully integrated with the demo app.

@TylerHelmuth TylerHelmuth added the chart:demo Issues related to opentelemetry-demo helm chart label Jan 6, 2025
@puckpuck
Copy link
Contributor

We have discussed this, and we would likely want to do it, but it needs to be done in the Demo repository first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:demo Issues related to opentelemetry-demo helm chart
Projects
None yet
Development

No branches or pull requests

3 participants