Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecation request for the AWS X-Ray Sampler #6576

Open
jj22ee opened this issue Jan 8, 2025 · 0 comments
Open

Undeprecation request for the AWS X-Ray Sampler #6576

jj22ee opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@jj22ee
Copy link
Contributor

jj22ee commented Jan 8, 2025

Problem Statement

The X-Ray Sampler was originally deprecated due to lack of ownership. This issue is to request for the sampler to be brought back into the OTel Go Contrib repo.

Proposed Solution

Previously, the sampler was deprecated because of a lack of ownership of the component.
I can commit to being its owner as I have a lot of X-Ray Sampler implementation knowledge (have e2e integration test setup and implemented X-Ray sampler in 2 other languages). I also recently became a CNCF project member.

One of the reasons to continue having the X-Ray Sampler hosted in the OTel Contrib repo is to allow the X-Ray Sampler to be available via the OTEL_TRACES_SAMPLER Environment Variable when that Environment Variable is supported in the future. This would also help support this sampler to be available for future zero-code auto-instrumentation.

@jj22ee jj22ee added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant